Ember 4.x compatibility and other fixes about ember-cli-conditional-compile

[halfbyte]

Okay, I guess no answer is also sort of an answer in this context.

No worries, I am not trying to put pressure on anyone here, just acknowledging the status quo. I know how difficult the maintainer situation in general in Ember land is right now.

If you are in need of 4.x compatibility, please check and test my fork and let me know if things break for you. Eventually I might publish that as a separate package if this here turns out to be truly abandoned.

[calvinlough]

Hey @halfbyte! The original maintainer got enticed by the dark side (Rails) so I don't think you'll see him around here any more. I do have merge and release permissions myself though and I'm still interested in seeing this project move forward.

Adding 4.x compatibility is great but it'd be great if you could keep 3.x support too (I'm still on 3.x).

Seems like the first priority should be getting the test suite passing. After that, if you could break up your changes into bite-sized pieces that would be great (or half-bytes).

[halfbyte]

Hey @calvinlough thanks for your answer, it's good to have someone to talk to!

Couple of questions before I can start:

• Would you be okay to move from Travis to GH actions so that we can be relatively close to the ember addon blueprint and also use a more future proof platform?
• Definitely will keep 3.x compatibility. All changes I did so far do work with the last two 3.x LTS versions. Does [this ember-try config] look useful to you? (We can of course discuss the finer details in a PR).

[calvinlough]

Yep, GH actions sounds great. When you say [this ember-try config] did you intend to put a link in there?

[halfbyte]

@calvinlough Haha, of course. To be fair, after reviewing it, it's probably more succinctly summarised as: Cutoff at 3.15 (I think 3.15 is where the new functional API we would need for 4.x was introduced) and let ember try figure out the rest.

[calvinlough]

Sounds great