Coder Social home page Coder Social logo

Comments (10)

Jacobwasbeast avatar Jacobwasbeast commented on June 11, 2024 3

I have made a fork that allows placement and uses and added a recipe as well. Its not very secure all I did was allow placement in survival and for it to be crafted nothing more nothing less. Go to the actions tab and either get the 1.19.2 version, which is master, or 1.18.2 from my fork.

from fabric-webstreamer.

mindstorm38 avatar mindstorm38 commented on June 11, 2024 1

I wonder if there is a more standard way of managing per-block permission in vanilla Minecraft? Or maybe with a fabric api?

from fabric-webstreamer.

mindstorm38 avatar mindstorm38 commented on June 11, 2024 1

LuckPerms keep advertising it as the standard way to interoperate with permissions... I agree that 7 months is a lot for an open source project, but there are no recent issues.

from fabric-webstreamer.

mindstorm38 avatar mindstorm38 commented on June 11, 2024

Hi! You're right, and the availability in non-creative mode of this block is a question since the beginning of the project.

Let me explain: each different source (live stream or raw images) present near a player (and rendered) are potentially using the network. This is a problem with live streams in particular, a player entering an area with too many different sources might get DDOS-ed just by the fact that the game will try to play all streams concurrently. This is why I didn't allow the block to be placed for non-op/non-creative players. Note that sources are not directly display blocks, for example the same source can be used on many displays and this won't cause much network lag, because the source is downloaded once, processed and then rendered at multiple locations.

To allow it in survival, I'll need to add either a permission system (to allow trusted players to place it) or a rate-limit, the best would be to implement both. The rate-limit is a lot harder to implement.

from fabric-webstreamer.

Sirmentio avatar Sirmentio commented on June 11, 2024

Honestly, my players would probably just make use of the static image feature before going ahead with full streams, which I assume wouldn't be nearly as taxing on one's network. Maybe streams of that nature could only work when changed via creative mode?
Alternatively, it could be a config option with a clear warning.

from fabric-webstreamer.

mindstorm38 avatar mindstorm38 commented on June 11, 2024

@Jacobwasbeast I'm really interested in the workflow you introduced together with the craft (which is fair), could you open a pull request (with all changes to gradle.yml squashed)? However, I'm not sure to keep the 1.18 version because I don't know how I can manage and release multiple MC versions at the same time, if you have any suggestion for this I'm interested.

from fabric-webstreamer.

Jacobwasbeast avatar Jacobwasbeast commented on June 11, 2024

Alright, I created a pull request.

from fabric-webstreamer.

ajh123 avatar ajh123 commented on June 11, 2024

Permissions with LuckPerms could be added to allow none-oped players place a web display, a permission like webstreamer.display.place could be used.

Many servers already use LuckPerms so this would be helpful for them to.

from fabric-webstreamer.

mindstorm38 avatar mindstorm38 commented on June 11, 2024

Looks like LuckPerms have a sub library that does exactly that https://github.com/lucko/fabric-permissions-api/

from fabric-webstreamer.

ajh123 avatar ajh123 commented on June 11, 2024

However, that API has had its last update 7 months ago.

from fabric-webstreamer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.