Cannot read property 'self' of undefined about sarala

[milroyfraser]

Hi @subotkevic thank you very much for constructive comments.
Fixed on 0.3.9 ✌️

[subotkevic]

Or maybe we should be able to define or override that URL in the model itself somehow?

But the best solution would be to have default self URL, which is the same in 99% of the time.

[subotkevic]

Currently I have temp solution from client side:

In my base model I just implemented update() method like this:

update() {
  return this.makePersistRequest({
    url: this.resourceUrl() + this.data().id,
    method: 'PUT',
    data: this.serialize(this.data())   
  })
}

So basically the same method just with different url element.

[subotkevic]

More news... Looks like _delete() method using self URL the same way, so currently I came across with something like this in my Base Model:

  update() {
    this.buildSelf()
    super.update()
  }

  _delete() {
    this.buildSelf()
    super._delete()
  }

  buildSelf() {
    const self = this.resourceUrl() + this.data().id

    if (this.hasOwnProperty('links')) {
      if (! this.links.hasOwnProperty('self')) {
        this.links.self = self
      }
    } else {
      this.links = { self }
    }
  }

[subotkevic]

Well, thank you for resolving this issue.

Not an issue though, but now it will be much more reusable.

[subotkevic]

By the way,

I checked your commits on that, and I can tell you that approach is good, but you forgot to handle the case when api will provide self url, so I think you need to additionally check for self url in the model, and if it does not exist, then use current approach.

Or, we need to have some setting in each model or just in base model which will define how user will want to use self urls - default, or from the response.

[milroyfraser]

@subotkevic Thanks for the input.

Sarata expects api to follow {JSON:API} Recommendations. In that case this is always the same.

But I agree with your point, as an improvement we can check it before generate it.