Yarn workspace issue with node-fetch about terraform-aws-next-js

[ofhouse]

Difficult to say without having a reproduction at hand.
Can you tell where the node-fetch package is installed, after you have run yarn?

root/
├── node_modules/
│   └── node-fetch/ <-- Is it here
└── web/
    └── node_modules/
        └── node-fetch/ <-- Or is it here

Can you also tell me which Next.js version you are using?

Basically dependencies are bundled by a tool called nft which runs a static analysis on the actual code which dependencies are required.
Since it follows the Require.js algorithm it should be able to catch the dependencies in both cases.
You can also check the result by opening the Lambda Zip files in .next-tf/lambdas/__NEXT_PAGE_LAMBDA_XX.zip which should contain node_modules/node-fetch directory.

[JoviDeCroock]

so all the deps are in root/node_modules and we're running yarn tf-next build --skipDownload in /web and we run terraform apply in /web/.aws/deployment.

When I remove web from the root pkg.json and have my modules in web it works correctly, I can try making a reproduction. Sorry for the vague issue report, will attempt to get it reproduced

[ofhouse]

No problem, setup a repro here: https://github.com/ofhouse/repro-terraform-aws-next-js-93
Can confirm that the tracing of dependencies with --skipDownload is broken in yarn workspace environment.

Running yarn in the workspace root and after that npx tf-next build in the web/ folder.
No node_modules are bundled with the Lambda which should not be happening.

[JoviDeCroock]

Managed to bypass the issue for now by running yarn workspace <my-env> build from the root rather than in the workspace itself. Good workaround for now 😅

EDIT: this does not fully fix the issue

[JoviDeCroock]

I guess we need to detect whether or not we're in a workspace here

[ofhouse]

Yep, worked a bit with nft last week, and baseDir must be the root of the workspace: https://github.com/dealmore/terraform-aws-next-js/blob/main/packages/runtime/src/index.ts#L1125

Will try to take a closer look into this today.

[ofhouse]

Okay, created a potential fix for this issue in #107.
Needs some testing, but I think this should solve the issue.

[hugheba]

Was the bug for the missing node_modules folder ever fixed?

I can build the .next-tf folder fine with the command ./node_modules/.bin/tf-next build --skipDownload but when I open the Lambda zips, they are missing the node_modules folder.

[ofhouse]

@hugheba The location where (cwd) the tf-next build is run from is important when running from a monorepo.

tf-next build should always be executed from the path where the next.config.js (or package.json) of the Next.js app is located.