Comments (10)
Good news, we finally have a new v0.2.0
release out that should fix the issue.
Please note that you also need to update the @dealmore/terraform-next-build
in your package.json
to 0.2.0
.
from terraform-aws-next-js.
I realized that I forgot to add a next.config.js
file to the repo, after adding the following,
module.exports = {
// Build the server for a serverless environment
target: 'serverless',
};
and rebuilding, I'm still seeing the same errors
from terraform-aws-next-js.
Thanks for creating & posting that example.
Will take a deeper look tomorrow. Could be possible that something broke with the latest Next.js 10 release, we haven't upgraded yet.
from terraform-aws-next-js.
I’ll also try and downgrade to 9.5 later and see if that fixes it. Thanks!
from terraform-aws-next-js.
Hmm - That didn't seem to help. Using [email protected]
still produces 404s - no errors in the logs. Let me know if you need anything else from me.
from terraform-aws-next-js.
Sorry for the delay. Checked it out and got the same result, so routing is definitely broken for this example.
Currently gearing up a better testing solution for real world examples which I expect to ship by tomorrow and then I can take a better look what happened in this case.
from terraform-aws-next-js.
No worries, and sounds good. I'm happy to help debug if needed
from terraform-aws-next-js.
Short update regarding this issue:
I've tracked the issue down to this code:
https://github.com/dealmore/terraform-aws-next-js/blob/main/packages/proxy/src/proxy.ts#L92
This was a workaround introduced for slug routes (e.g. /some-page/[...slug]
) that we mostly rely on for our own projects.
While it works for slug-routes it breaks dynamic routing (e.g. /some-page/[id]
) at this point because it cuts the arguments from the URL and prevents the dynamic part from being passed to the lambda.
To prevent the issue in the future we set up an local e2e testing (proxy -> lambda) in #17 powered by AWS SAM and introduce further unit tests to cover that use cases.
Routing is a bit complicated here because it is mostly based on reverse engineering Vercel's proxy solution but with the testing we should have a solution ready soon.
from terraform-aws-next-js.
Thanks @ofhouse for the update! Looking forward to the fix. Let me know how I can help
from terraform-aws-next-js.
@andrewgadziksonos ok, end of the year was busier than I thought, so sorry again for the delay on this issue 🙈.
I finally implemented a working solution for the issue and the e2e tests results also confirm that it is working.
I track the current status in #17 and when CI is green we are ready for a new release 😬
Unfortunately there is still one test failing for a fallback route.
Since fallback routes didn't work before either I think this is not necessarily linked to this issue and we may defer support for fallback routes in a feature request.
Will make decision on this tomorrow and then I will publish a new release.
from terraform-aws-next-js.
Related Issues (20)
- Modify proxy to force a version change HOT 1
- Unable to attach policy to lambda, since the iam.tf is missing in all versions starting from 1.0.0-canary.2 HOT 1
- Error: Authentication Failed Returns Status Code 0
- What services does this library use internally to manage deployments? HOT 1
- Unable to use redirect inside getServerSideProps HOT 3
- [Bug] Error while using middleware from Next 12.2 HOT 1
- TimeoutError: Promise timed out after 300000 milliseconds HOT 1
- Question: how can I use this module if I am using Cloudflare for DNS management and WAF? HOT 2
- Dynamic Routes like [id].tsx doesn't be update in my github action
- Q: What permissinos are needed for deployment? HOT 1
- Next.js v13 support HOT 10
- One or more of the CNAMEs you provided are already associated with a different resource. HOT 1
- Cannot deploy - .next-tf/lambdas\__NEXT_PAGE_LAMBDA_0.zip: no such file or directory HOT 1
- Is there a localstack sample available? HOT 1
- Getting Error during creating resources with terraform
- Deployment not deletes old files from s3 HOT 1
- NextAuth CLIENT_FETCH_ERROR , NEXTAUTH_URL
- New deployments not possible due as AWS ACLs are disabled by default HOT 1
- Alternatives? HOT 2
- Lambda functions no longer support NodeJS `v14` . HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-next-js.