Comments (6)
Hi! I'm your new maintainer. :)
Is it possible to define the instance outside enummapset? Do we expose enough internals? Are the definitions very long? I think I'd rather have another package that depends on enummapset and adds a lot of instances. Some people would not depend on that new package anyway, but just copy-paste only the instances they need, but that's fine. OTOH, they can't copy-paste enummapset easily, so I'd keep its deps small. What do you think?
from enummapset.
It is possible but I mean that has all the usual downsides of orphan instances. I suppose we could also ask the maintainers of the classes to depend on enummapset
like they depend on containers
already.
from enummapset.
A long shot, but surely try talking with maintainers of these packages and perhaps link back to this issue. Talking and being aware of each other is always a good idea. Regarding orphans, it's unfortunate, but currently that's a common thing with many other packages.
from enummapset.
I will create those issues now. Perhaps the long term solution is to convince people that EnumMap
belongs in containers (as well as or instead of IntMap
).
We really do need a proper long term language-level solution for orphans though.
from enummapset.
Agreed on all accounts. Thanks for that. Perhaps separate IntMap
and EnumMap
in containers make most sense, because EnumMap
needs some base operations to inline to, and IntMap
fits this role perfectly. Also if some people have some particular use case where they use honest, arithmetic Int
s all over the place, they can underscore this rare situation by using IntMap
and also they don't need the notation and compilation overhead of EnumMap Int
.
from enummapset.
Slightly related: I noticed http://hackage.haskell.org/package/regex-tdfa defines its own EnumMap
and `EnumSet'. If that was part of containers, they'd surely use the version from base instead of rolling their own.
Edit: ChrisKuklewicz/regex-tdfa#19
from enummapset.
Related Issues (10)
- Please provide `Data`, `Typeable`, `Foldable` and `Traversable` instances HOT 4
- Build failure with GHC 8.4 HOT 3
- Feature request: add disjoint from containers 0.5.11.0
- Build failure with GHC-8.6 and containers-0.6 HOT 3
- Push new release to Hackage HOT 2
- Apply the foldl' patch from head.hackage HOT 9
- Minor: make the result of Show compilable HOT 1
- Build failure "Can't make a derived instance of 'Traversible (EnumMap k)'". HOT 2
- name change proposal (EnumMap => Map, EnumSet => Set) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enummapset.