Coder Social home page Coder Social logo

Comments (14)

mikepenz avatar mikepenz commented on June 13, 2024 1

Thank you for testing it.

So you would like to have:

  • checks
  • summary
  • but not annotations
    (if I understand correctly?)

from action-junit-report.

janbernhardt avatar janbernhardt commented on June 13, 2024 1

Summary details look like this
image

from action-junit-report.

mikepenz avatar mikepenz commented on June 13, 2024

Good day.

Setting annotations_limit to zero would actually result in no annotations being collected at all, and I suppose you still want them to show up in the summary.

If I understand you want the summary only, but no annotations whatsoever? (Basically skipping this: https://github.com/mikepenz/action-junit-report/blob/main/src/main.ts#L110-L119 ?)

from action-junit-report.

mikepenz avatar mikepenz commented on June 13, 2024

Please feel free to try out this branch to see if it matches what you were looking for: #1022

from action-junit-report.

janbernhardt avatar janbernhardt commented on June 13, 2024

Wow that was a super fast response. Very impressive!! I will test it and let you know.

from action-junit-report.

janbernhardt avatar janbernhardt commented on June 13, 2024

The summary_only skips the annotations as desired, but unfortunately it also skips the check report.

I would like to still see the check report but not the annotations.

Maybe a better option could be annotate_error which is true by default, but can be set to false to mute the error annotations.

from action-junit-report.

janbernhardt avatar janbernhardt commented on June 13, 2024

yes, I want to show all the details, but not as an annotation error on top level of my workflow. I'm using it to show CVE issues from used dependencies, so there could be a lot of them. I want the users to be able to see the full list but I don't want to highlight them all in the annotations.

from action-junit-report.

mikepenz avatar mikepenz commented on June 13, 2024

Thank you for your feedback. Based on this I decided to go a different route. This should be what you are looking for:

New setting to disable the annotations for checks (does not affect. if annotate_only is used)

from action-junit-report.

janbernhardt avatar janbernhardt commented on June 13, 2024

Annotations are gone as desired. But my Check report is empty now as well. This is not desired, as I would still like to see the failed tests on the check report.

Now:
image

Previous and desired output on the check would be:
image

from action-junit-report.

janbernhardt avatar janbernhardt commented on June 13, 2024

Maybe it is not possible to skip the annotations on the check summary...
I just want to avoid the Annotations on the build summary

image

from action-junit-report.

mikepenz avatar mikepenz commented on June 13, 2024

@janbernhardt unfortunately this is not possible as far as I am aware.

The annotations section is filled by GitHub automatically with the annotations created.

from action-junit-report.

mikepenz avatar mikepenz commented on June 13, 2024

The summary could serve as alternative, however it's also not exactly the same

from action-junit-report.

janbernhardt avatar janbernhardt commented on June 13, 2024

Yes, you are right. Good point.

from action-junit-report.

janbernhardt avatar janbernhardt commented on June 13, 2024

So from my point of view, you can merge this change back into master :-)

from action-junit-report.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.