Review CORS support for amplify.request about amplify

[mrdavidlaing]

Let me know if you'd like me to package files in a different place before submitting a patch (I don't really understand how your build process works)

[jdsharp]

Hey David,

Will do, our build process is an internal tool that we'll be releasing shortly, but it's not quite finished being baked yet.

Cheers,

• Jonathan

[mrdavidlaing]

Bump - any update on this?

[scottgonzalez]

Thanks, but this seems out of scope. There really shouldn't be a CORS type, this should be built into the ajax type. If there's a change that needs to be made in amplify.request in order to allow you to build a plugin that does that, let us know. We're very interested in allowing reasonable extensions.

It's unfortunate that CORS is a mess, but I don't want to ship code in amplify that relies on browser plugins such as Flash. Also, since this uses jQuery's ajax transports, it won't work with all of the versions of jQuery that we support.

[mrdavidlaing]

Hi Scott,

In my case, I have to support CORS requests on IE7, and the only way I can
see to do this is using a Flash transport.

If you could expose a way to override the XHR that is being used; then
perhaps this plugin could be more "low level"

What do you think?

David

2011/9/9 Scott González <
[email protected]>

Thanks, but this seems out of scope. There really shouldn't be a CORS type,
this should be built into the ajax type. If there's a change that needs to
be made in amplify.request in order to allow you to build a plugin that does
that, let us know. We're very interested in allowing reasonable extensions.

It's unfortunate that CORS is a mess, but I don't want to ship code in
amplify that relies on browser plugins such as Flash. Also, since this uses
jQuery's ajax transports, it won't work with all of the versions of jQuery
that we support.

Reply to this email directly or view it on GitHub:
#20 (comment)

David Laing
Open source @ City Index - github.com/cityindex
http://davidlaing.com
Twitter: @davidlaing

[scottgonzalez]

jQuery already provides jQuery.ajaxSettings.xhr.

2011/9/9 David Laing <
[email protected]>

Hi Scott,

In my case, I have to support CORS requests on IE7, and the only way I can
see to do this is using a Flash transport.

If you could expose a way to override the XHR that is being used; then
perhaps this plugin could be more "low level"

What do you think?

David

2011/9/9 Scott Gonzlez <
[email protected]>

Thanks, but this seems out of scope. There really shouldn't be a CORS
type,
this should be built into the ajax type. If there's a change that needs
to
be made in amplify.request in order to allow you to build a plugin that
does
that, let us know. We're very interested in allowing reasonable
extensions.

It's unfortunate that CORS is a mess, but I don't want to ship code in
amplify that relies on browser plugins such as Flash. Also, since this
uses
jQuery's ajax transports, it won't work with all of the versions of
jQuery
that we support.

Reply to this email directly or view it on GitHub:
#20 (comment)

David Laing
Open source @ City Index - github.com/cityindex
http://davidlaing.com
Twitter: @davidlaing

Reply to this email directly or view it on GitHub:
#20 (comment)