not taking param into consideration? about laravel-model-caching

[mikebronner]

Thanks for reporting this @shez1983 ! I'll take a look as soon as I get back to the office on Tuesday. In the mean time, can you provide the SQL representation of both queries?

[shez1983]

i'll make sure I update this post before tuesday.. Thanks :)

[mikebronner]

If you are able to, please include the stack trace as well. I do have about 30 minutes to look at it right now, if you are able to update the code :)

[mikebronner]

Related or same as #66

[mikebronner]

@shez1983 Are inRandomOrder() and live() query scopes? Can you paste them here as well? Thanks! :)

[shez1983]

I am sorry for the delay... :(

"select * from `product_variants` where exists (select * from `products` where `product_variants`.`product_id` = `products`.`id` and `category_id` = ? and `status_id` = ? and `show_on_mobile` = ?) and `is_listed` = ? and (`stock` is null or `stock` > ?) and `product_variants`.`deleted_at` is null order by RAND()"

Here is the live Scope

    {
        return $q->whereIsListed(1)->where(function($q)
        {
           return $q->whereNull('stock')->orWhere('stock', '>', 0);
        });
    }

inRandomOrder is an ELOQUENT/Builder function btw..

I am not sure how to include a stack trace because theres no error..

[mikebronner]

@shez1983 thanks for the update. In your eloquent query you aren't specifying get()? Was that just a typo, or are you using a different command?

[shez1983]

yes. as i said i can see the actual products.. if i didnt specify get() i wouldnt have come to the conclusion of my OP.. :)

[mikebronner]

Hi @shez1983, I am unable to reproduce this problem in version 0.2.37. Can you test again? I have added a test that checks the caching for the whereHas() method. Please let me know how it goes! :)

See test here: https://github.com/GeneaLabs/laravel-model-caching/blob/master/tests/Unit/CachedModelTest.php#L77

[mikebronner]

@shez1983 closing this for now, please let me know if you continue to have this problem.

[shez1983]

oops sorry - too busy with work will let you know sometime (by next week)

btw that link https://github.com/GeneaLabs/laravel-model-caching/blob/master/tests/Unit/CachedModelTest.php#L77 doesnt seem to be working :s
@mikebronner

[mikebronner]

Try this:
https://github.com/GeneaLabs/laravel-model-caching/blob/master/tests/Integration/CachedModelTest.php#L77

[shez1983]

Thanks for that - seeing your test, it seems you have not understood my problem...
that test is not recreating what i said in my op..

in that test i expected you to cache both

            ->with('author')
            ->whereHas('author', function ($query) {
                $query->whereId(1);
            })
            ->get();

and

            ->with('author')
            ->whereHas('author', function ($query) {
                $query->whereId(2);
            })
            ->get();

and then make sure the results are not the same..

notice the Ids.. are different

[mikebronner]

Thanks for clarifying, that indeed was not clear in your initial post. I will try to recreate the problem as you just described.

[mikebronner]

@shez1983 I added the following test: d003028

Does this follow your use-case? I was unable to replicate the issue.

[shez1983]

•    $this->assertNotEmpty($books1->diffKeys($books2)); 
  

surely this should assertEMPTY if there can only be one author for a book? and you are not caching the results...

you are supposed to be looking at cached results (Unless i am missing something) not comparing eloquent/query results...

[mikebronner]

Your original post was saying that running two different queries actually returns the same information. Do I understand that correctly?

This test does use caching, and it verifies that the results from each cached query are different. That is to say, that the results provided in $books2 are not the same as those in $books1. Since whereHas queries are cached, as verified in the test above this one, it is not necessary to verify that. We only need to make sure that the second query is not pulling the cache from the first query.

Have you actually been able to recreate this issue with the latest version of the package?

[shez1983]

yes thats correct. in your previous test (link you provided:
https://github.com/GeneaLabs/laravel-model-caching/blob/master/tests/Integration/CachedModelTest.php#L77

you were doing

$cachedResults = $this
            ->cache()
            ->tags($tags)
            ->get($key)['value'];
        $this->assertEquals(1, $books->first()->author->id);
        $this->assertEquals(1, $cachedResults->first()->author->id);

so i was expecting something similar in your latest test you did... d003028

anyway i will re-test (i actually tested it again few days after posting to make sure i didnt make an error) & let you know

[mikebronner]

Thanks, I look forward to seeing how it works for you! :)

[mikebronner]

HI @shez1983, closing this for now. If there are still issues, please go ahead and re-open. Thanks :)