Coder Social home page Coder Social logo

Comments (9)

MiguelNdeCarvalho avatar MiguelNdeCarvalho commented on September 6, 2024

Hey,

This is a good idea. I will take a look on the PR.

Really thanks,
MiguelNDeCarvalho

from speedtest-exporter.

markafarrell avatar markafarrell commented on September 6, 2024

@MiguelNdeCarvalho I have built an image based on my PR that I have been using for the past few days and it seems to be working fine https://hub.docker.com/layers/158995196/markfarrell/speedtest-exporter/3.3.0/images/sha256-8236e265f0bba1454da0c612c36ce6789ac9e984f0b4f7ca6e44405fc0140d5f?context=repo

from speedtest-exporter.

MiguelNdeCarvalho avatar MiguelNdeCarvalho commented on September 6, 2024

Really thanks for your contribuition @markafarrell. I have made some comments from what we should change before merge it

from speedtest-exporter.

markafarrell avatar markafarrell commented on September 6, 2024

@MiguelNdeCarvalho I can't seen any comments anywhere? Did you need me to change something?

from speedtest-exporter.

MiguelNdeCarvalho avatar MiguelNdeCarvalho commented on September 6, 2024

Hey,

I have just requested some changes on the PR, can you see them?

Thanks,
MiguelNdeCarvalho

from speedtest-exporter.

markafarrell avatar markafarrell commented on September 6, 2024

@MiguelNdeCarvalho Nope. I don't see anything in #84

from speedtest-exporter.

MiguelNdeCarvalho avatar MiguelNdeCarvalho commented on September 6, 2024

Can you check now please? Thanks

from speedtest-exporter.

markafarrell avatar markafarrell commented on September 6, 2024

I see them now. Thanks

from speedtest-exporter.

MiguelNdeCarvalho avatar MiguelNdeCarvalho commented on September 6, 2024

Fixed in #86, really thanks for the help. Feel free to reopen if needed

from speedtest-exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.