Comments (8)
I guess we are missing something in what he did in one of those commit related to fling.
Someone from my last company show me the app behavior in one smartphone with an old version of this library and the new one (he download my app from the market and that one has the last commit). In old one I tried like 12341234 times reproduce the issue related to "jump" anchor_point and get from collapsed to expanded in one shoot but I couldn't. Meanwhile in the news one was easy to reproduce it.
So I guess we are missing a little logic behind those changes.
from custombottomsheetbehavior.
Sorry - I am not clear on what the issue is. Are you saying the 'stop at anchor' worked BEFORE PR#27 and doesn't work AFTER PR#27?
from custombottomsheetbehavior.
In somehow yes, I mean, like I said, I tried so many times in an old version of the lib and I couldn't reproduce "jump state" behavior (It could be I didn't try in the right way... no idea). But what I'm sure is that was easy to reproduce it using last version of the lib, so I'm guessing we are missing some logic in the new fling behavior.
from custombottomsheetbehavior.
Can you take a look at my fork and see if everything works? I've made many changes over the past few days. If it works I can issue a PR.
https://github.com/vit001/CustomBottomSheetBehavior
from custombottomsheetbehavior.
My phone died unfortunatelly so I am stuck with the emulator for a couple of days , very clunky... :(
from custombottomsheetbehavior.
OK, I see the issue - I have my BottomSheet in a Horizontal ViewPager (another layer of NestedScrollingParent), so some of the code doesn't work the same in your lib demo. I am going to push out my Horizontal ViewPager code as a lib so you can take a look, and maybe you'll find use for the paging ability as well ... :)
from custombottomsheetbehavior.
yeah, because all the different configurations you can have with this lib, I'm going to make 2 or 3 demos plus the principal one. It sounds good having integration with that lib you are going to release.
note: I don't like how it sounds when you say "in your lib" :D. I mean, I just started this lib but it has grown because @akaN44 and you... so it's better if you say "our lib".
from custombottomsheetbehavior.
@miguelhincapie - Still working on a clean demo and fixing toolbar, but you can check out https://github.com/vit001/CustomBottomSheetBehavior - the paging and scrolling works perfrect for me.
By the way, if you don't want the horizontal pager functionality, you can always provide an adapter with only one item.
from custombottomsheetbehavior.
Related Issues (20)
- NullPointerException at 288 line in BottomSheetBehaviorGoogleMapsLike HOT 20
- How to prevent STATE_COLLAPSED and STATE_HIDDEN? HOT 3
- main status bar color HOT 2
- crash with compile sdk version HOT 6
- The view is not associated with BottomSheetBehaviorGoogleMapsLike
- FATAL error on Viewdragger helper HOT 1
- How do I change MargedAppBarLayout's TitleTextColor?
- to vit001: How do I use your CustomBottomSheetBehavior custom lib (with your own viewpager)? HOT 4
- Parallax effect and Merged AppBar problems HOT 7
- Wrong behavior when the keyboard is shown
- What to do if PeekHeight > ToolbarHeight + StatusBarHeight
- crash with sdk 28 HOT 2
- Backdrop View is not showing properly in some cases, it doesn't animate to Anchor point.
- Header card should completely hide behind Toolbar
- Use in Kotlin has an error
- how to add custom view Toolbar when set STATE_EXPANDED
- Anchor Point state is not proper when it is set to 156dp
- Disable dragging on BackdropBottomSheetBehavior
- Clashing in defaultState attribute naming with ConstraintLayout 2.0 HOT 2
- Could not find com.mahc.custombottomsheetbehavior:googlemaps-like:0.9.4. in Gradle 7.2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from custombottomsheetbehavior.