Coder Social home page Coder Social logo

Comments (6)

OfficialEsco avatar OfficialEsco commented on May 21, 2024 1

You are still not wrong tho, i'm pretty sure it only does this for MSI's, i also thought it didn't add ProductCode's until i had to babysit wingetcreate new PR's the last 2 days because a bunch of people with A LOT less knowledge then you found out about it 😄

microsoft/winget-pkgs#15518 for example didn't pick up the ProductCode, however when you do get-wmiobject Win32_Product | Sort-Object Name | Format-Table IdentifyingNumber, Name -AutoSize you'll get the ProductCode

from winget-create.

palenshus avatar palenshus commented on May 21, 2024 1

microsoft/winget-pkgs#15518 for example didn't pick up the ProductCode

This is strange, I couldn't repro. When I ran:

wingetcreate new new https://product-downloads.atlassian.com/software/sourcetree/windows/ga/SourcetreeEnterpriseSetup_3.4.4.msi

It correctly parsed the ProductCode:

# Created using wingetcreate

PackageIdentifier: Atlassian.Sourcetree
PackageVersion: 3.4.4.0
Installers:
- InstallerLocale: en-US
  Architecture: x64
  InstallerType: msi
  InstallerUrl: https://product-downloads.atlassian.com/software/sourcetree/windows/ga/SourcetreeEnterpriseSetup_3.4.4.msi
  InstallerSha256: 758AAA6A48E1C195B0C0A234AD2CF1FEE6B720F4A6DE6320F060272BBED73180
  ProductCode: '{0A007AE6-6A0D-42DB-8CF5-6E6E178E923C}'
ManifestType: installer
ManifestVersion: 1.0.0

It's possible the user removed it manually. You are correct though that the Update command should update it as well

from winget-create.

OfficialEsco avatar OfficialEsco commented on May 21, 2024

wingetcreate new actually does add the ProductCode, i believe it uses Get-AppLockerFileInformation which works most of the time, but not for everything.
wingetcreate update does however not fetch the ProductCode.

from winget-create.

tiziodcaio avatar tiziodcaio commented on May 21, 2024

Woops sorry I'm not so expert... Sorry for saying fake things :/

from winget-create.

palenshus avatar palenshus commented on May 21, 2024

Okay, so given that this just covers changing the Update command to update the ProductCode, I'm going to close as a Duplicate of #22

from winget-create.

 avatar commented on May 21, 2024

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

from winget-create.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.