[osg] Build failure on x64-windows about vcpkg

[gfyrtuwcv]

I want use GL3 build osg, added a line of set(osg_OPENGL_PROFILE "GL3") to the x64-windows.cmake file. And then there's this problem

[LilyWangLL]

Duplicate of #33008

[gfyrtuwcv]

I reinstalled VS2022 and installed the latest MSVC 14.39.33519, but I still got an error，It seems that min\max and std:: min () and std:: max () are conflicts defined by Visual C ++. I don't know how to solve them

[dg0yt]

Some configuration seem to include windows.h before or without defining NOMINMAX.

[gfyrtuwcv]

I added -DNOMINMAX=ON at vcpkg_cmake_configure(OPTIONS) in vcpkg\ports\osg\portfile.cmake , like this
vcpkg_cmake_configure( SOURCE_PATH "${SOURCE_PATH}" OPTIONS ${FEATURE_OPTIONS} -DNOMINMAX=ON
And add add_definitions(-DNOMINMAX) to vcpkg\buildtrees\osg\src\raph-3.6.5-c3f8c61ada.clean\CMakeLists.txt .
Not sure which one worked, but osg is installed!

[dg0yt]

I added -DNOMINMAX=ON at vcpkg_cmake_configure(OPTIONS) in vcpkg\ports\osg\portfile.cmake , like this vcpkg_cmake_configure( SOURCE_PATH "${SOURCE_PATH}" OPTIONS ${FEATURE_OPTIONS} -DNOMINMAX=ON And add add_definitions(-DNOMINMAX) to vcpkg\buildtrees\osg\src\raph-3.6.5-c3f8c61ada.clean\CMakeLists.txt . Not sure which one worked, but osg is installed!

I don't believe this is the fix. It must be passed to the compiler (preprocessor macro), not to cmake (option).
add_definitions is the key.

[gfyrtuwcv]

In fact, I changed the portfile.cmake configuration to run vcpkg install osg，then add 'add_definitions(-DNOMINMAX)' to vcpkg\buildtrees\osg\src\raph-3.6.5-c3f8c61ada.clean\CMakeLists.txt .
Probably made it work by changing the CMakeLists before it started building, which I know is not a good idea, but haven't figured out a better way