Comments (5)
This is a correct error; you could write
type MyRouter = {
[Symbol.isConcatSpreadable]: number;
}
type M = GetRouteResponseInfo<MyRouter, typeof Symbol.isConcatSpreadable>;
at which point Router[Path]
has type number
, which there's no ReturnType<>
of
from typescript.
hey @RyanCavanaugh, I'm not sure you understand my point.
TypedRouter
retruns R which is contained to be at least {[key: string]: (args: any) => any;}
(even if any is passed, like in TypedRouter<any>
), and because Router extends TypedRouter<any>
, then Router is also constrained to {[key: string]: (args: any) => any;}
. so keyof Router
would forever be string
, and Router[Path]
would forever be a valid function.
In your example, You just assumed a route key of type number
which is not possible (because the constrain on R in TypedRouter
). your example that not explain why this is 'Working as Intended` at all.
and if so, why does holding the type inside nested prop fixes the issue and the compiler does not complain anymore?
from typescript.
then Router is also constrained to
{[key: string]: (args: any) => any;}
This index signature only constrains what's present at string keys. It doesn't bar what happens at symbol keys
type MyRouter = {
[Symbol.isConcatSpreadable]: number;
}
type IsRouter<T extends TypedRouter<any>> = T;
type Test = IsRouter<MyRouter>; // Not a constraint violation
from typescript.
I think I get it now, and it does not relates to the way index signature checks symbols.
actually, in your example you can use 'random'
literal (or any other random type), and it wouldn't be a constrain violation.
export type TypedRouter<
R extends {
[key: string]: (args: any) => any;
}
> = R;
type IsRouter<T extends TypedRouter<any>> = T;
type Test = IsRouter<'random'>; // <-- Not a constraint violation
this is because when checking for T extends TypedRouter<any>
, typescript checks if R=any
extends {[key: string]: (args: any) => any;}
(and it does), so is it returns R(any
) without farther constraining it to {[key: string]: (args: any) => any;}
, which we can debate if is excepted(for user perspective) or not.
in other words,
type IsRouter<T extends TypedRouter<any>> = T;
is resolved to
type IsRouter<T extends any> = T;
(because TypedRouter<any>=any
)
instead of
type IsRouter<T extends {[key: string]: (args: any) => any}> = T;
(because any
in TypedRouter<any>
should be narrowed down to {[key: string]: (args: any) => any}
as R
in TypedRouter
applies)
i would claim that this is not expected, and the type should be narrowed down(but that just my opinion 🫠).
nevertheless, because the type are not narrowed down, you are correct that this works as intended, and this issue can be closed.
but one last thing, is there is documentation/issue that explains the design choice to not narrowing down returned generic types by their constraint? (in other words, why TypedRouter<any>=any
instead of {[key: string]: (args: any) => any}
)
from typescript.
Related Issues (20)
- Documentation: "Creating and Printing a TypeScript AST" example does not work after v4.9.5
- `satisfies` does not work on a variable called `type`
- API: Can't seem to extract JsDoc tags from declaration HOT 2
- Add option to detect and strip internal exports
- Unable to declare an interface that extends `Record<string, nonAnyType>` with additional support functions. HOT 7
- Add support for generic types on a index accessor HOT 4
- `getTextOfJSDocComment` is stripping `#` from JSDoc comment HOT 1
- Enable `allowJs` with `isolatedDeclarations` HOT 1
- JSDoc comment string with the keyword "@private" before import statement in JS file result in cryptic error TS1191 during compilation HOT 2
- `NoInfer` isn't erased and breaks type narrowing HOT 3
- function with overloading incorrectly defines generic variables HOT 3
- TS2590: Expression produces a union type that is too complex to represent, with simple file using Tuples HOT 6
- Debug Failure in transformClassLike in "ghost" after #56955 HOT 1
- no error when re-exporting wildcard import from module and redefining a name from it HOT 1
- TypeScript Error only on big type only when assigned to a variable HOT 3
- Allow explicit declaration of an object property to be omitted when the property is typed as `undefined` HOT 5
- generic parameter is not narrowed down correctly in extends clause when using keyof operator HOT 4
- OOM typescript, mac m1+. HOT 1
- [NewErrors] 5.5.0-dev.20240421 vs 5.4.5 HOT 63
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.