Support importing types from a `.mts` file from within a CommonJS file. about typescript

[RyanCavanaugh]

We should at least update the error message to suggest the resolution mode assertion

[RyanCavanaugh]

@andrewbranch points out that the concerns in the linked issue are specific to resolution hitting different targets in upstream packages due to revisions in their package jsons, but this argument doesn't apply at all to local relative paths

[RyanCavanaugh]

Duplicate #52529 edit: maybe?

[andrewbranch]

The currently intended behavior is that you’re supposed to silence this error by adding with { "resolution-mode": "import" } to assert that you’re doing what you’re doing on purpose. At minimum, we need to update this error message to suggest that workaround, but I was finding it hard to construct a message that adequately explains what’s wrong with this code, since I’m still somewhat skeptical that there’s anything wrong with this code.

[jakebailey]

I'm confused; isn't the context of this issue nodejs/node#51977, such that when that's "final", we need to have a new module resolution mode which re-allows require(ESM)? And that this issue isn't about anything else?

(Hm, maybe not, as the above was just a "side point" of sorts...)

[Jason3S]

@andrewbranch,

with { "resolution-mode": "import" }

This solves the my main issue. I did search for this, but wasn't able to figure it out based upon #53656. I was also trying to use verbatimModuleSyntax, but that doesn't work with CommonJS files.

I completely missed typescriptlang.org Stable Support resolution-mode in Import Types. I knew about with { type: "json" }.

By the way, the "value" of "resolution-mode" doesn't seem to matter for local files.

This works fine.
src/code.cts

import type { User } from './models.mts' with { "resolution-mode": "require" };

Which leads to the question of why resolution-mode is necessary for local files.

@jakebailey,

I'm confused; isn't the context of this issue nodejs/node#51977, such that when that's "final", we need to have a new module resolution mode which re-allows require(ESM)? And that this issue isn't about anything else?

(Hm, maybe not, as the above was just a "side point" of sorts...)

It is a "side point", I was using it as part of the argument that importing ESM files from a CJS file is necessary to support. Given that, it would also preclude the need for with { "resolution-mode": "import" }

[andrewbranch]

Yeah, if that lands without a flag, there will be a new module mode / nodenext will be updated to support it without error. There’s nothing to do on that front yet.