Coder Social home page Coder Social logo

Comments (4)

cplepage avatar cplepage commented on April 30, 2024 1

@RyanCavanaugh definitely, I will build a little something to make this issue reproducible and figure out what could go on. But I will need some time. Please allow me 1-2 week and I will come back here with a clear workable playground.

from typescript.

cplepage avatar cplepage commented on April 30, 2024 1

The easiest way to reproduce will be to run it as I encountered the issue.

Requirements

  • Git
  • Node >=18
  • MacOS (issue is only in Safari)

Setting up

  1. Clone the FullStacked Editor repo
  2. Checkout the typescript branch
  3. Pull all submodules
  4. Build TypeScript
  5. Install FullStacked Editor deps
  6. Start with the MUI sample repo
  7. Wait until the MUI sample project launches

Do all of this by copy/pasting the below snippet in Terminal.
Some of these steps will take quite a while.
Full process is up to 10 minutes.

git clone https://github.com/fullstackedorg/editor.git; cd editor
git checkout typescript
git submodule update --init --recursive --progress
cd lib/typescript; npm i; npm run build; cd ../..
npm i
npm start -- "https://github.com/fullstackedorg/editor-sample-mui.git?branch=ts"

*If at the end of the process you are not in Safari, close all popped up tabs and open http://localhost:9000 in Safari.

Testing the issue

In Safari, in FullStacked Editor, in the fullstackedorg/editor-sample-mui project,

  1. Open any .ts/.tsx file and wait for the TypeScript icon (top-right) to stop flashing.
  2. Open up the debug console, go in the Timelines tab and start recording.
  3. Edit the opened .ts/.tsx file constantly (hit enter at an interval of 1-2s) and monitor the memory. It should stay around 500-700mb

Now with your favorite code editor, open and comment out lib/TypeScript/src/services/services.ts#1802. Then, in Terminal, stop and rerun npm start and redo the three steps above. Check the memory climb nonstop (will go beyond 1GB).

from typescript.

cplepage avatar cplepage commented on April 30, 2024

Safari web inspector, running TS language service to getDiagnostics on file update.

without fix:
Screenshot 2024-04-09 at 3 25 25 PM

with fix:
Screenshot 2024-04-09 at 3 27 02 PM

from typescript.

RyanCavanaugh avatar RyanCavanaugh commented on April 30, 2024

Accepting PRs to fix memory leaks, but we obviously can't really investigate something without a repro

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.