Comments (8)
Changing to spec issue. The new compiler supports merging of all module declarations, including ambient external module declarations. I see no reason why we should only allow merging of internal modules and specifically disallow merging of ambient external modules. In particular, declaration files sometimes extend existing internal modules and may want to do exactly that for ambient external modules.
from typescript.
From design meeting: agreed this should merge just like internal modules.
from typescript.
Leaving open so we can make the text change to the spec
from typescript.
When I run this code in typescript I get
ldixon/foo.ts(4,16): error TS2000: Duplicate identifier '"fs"'. Additional locations:
ldixon/foo.ts(1,16)
ldixon/foo.ts(4,16): error TS2191: Ambient external module declaration cannot be reopened.
Sounds like the correct behaviour is no errors. Would be great to have an npm publish of a version with this fixed :)
from typescript.
agreed this should merge just like internal modules.
DT actually needs this. Thanks guys (/cc @Bartvds @vvakame will possibly make non-instantiated modules less necessary)
from typescript.
It seems like this doesn't work if the module is exported by assignment?
declare module "m" {
function inner(s: string);
module inner { export interface Test {t: string;} }
export = inner //error here
}
declare module "m" {
// even though we're only extending already existing submodule
module inner { export interface Other { t: number; } }
}
from typescript.
@spion The name inner
is not "shared" between declarations here -- when there's an export =
, all other declarations inside that module declaration are considered to not be visible at all
from typescript.
@RyanCavanaugh I see. The original problem is express.d.ts
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/express/express.d.ts
Here, express exposes a namespace Express
to let us extend Request
. Unfortunately those extensions cannot contain types imported from ambient external modules, which means they're of limited use. However, since express-the-module is also a function, the only way to declare the module is to use declaration merging then write export = module at the end, so we can't use declaration merging for ambient external modules either.
I'll open a separate issue.
from typescript.
Related Issues (20)
- Allow type annotations in .js files in preparation for Type Annotations proposal
- Refactor: move to new file does not work HOT 4
- Variables (extracted from a discriminated union object) lose narrowed types after being exported HOT 2
- Number.prototype.toFixed, Number.prototype.toExponential,Number.prototype.toPrecision comments error HOT 3
- Newly introduced type narrowing via discriminators on .filter does not work in this case HOT 9
- Long running encodedSemanticClassifications-full request HOT 3
- 5.6.0 regression: Incorrect param type inference for type with all optional props HOT 6
- Make type narrowing for destructured discriminated unions work for more types HOT 1
- Design Meeting Notes, 8/16/2024 HOT 3
- Inheriting from 21 combined mixins causes "type instantiation is excessively deep and possibly infinite" HOT 5
- `void` is treated as covariant with everything when overriding a method from a base class HOT 2
- Type Instantiation is Excessively Deep Regression In #56004
- Signatures with less parameters aren't assignable to compatible targets with more when their rest param is an instantiated `NoInfer` HOT 1
- Enable JSX.Element to be checked based on the element type HOT 3
- [NewErrors] 5.6.0-dev.20240818 vs 5.5.4 HOT 73
- Add `--strictObjectIterables` (bikeshed): exclude primitive (`string`) from `Iterable` types HOT 3
- [ServerErrors][JavaScript] 5.6.0-dev.20240818 vs 5.5.4 HOT 7
- [ServerErrors][TypeScript] 5.6.0-dev.20240818 vs 5.5.4 HOT 15
- `getTextOfJSDocComment` introduces a space in JSDoc comments HOT 1
- [tsserver] Make "configure excludes" warning more debuggable HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.