Coder Social home page Coder Social logo

Freeze & crash Windows Terminal Preview 1.21.1272.0 with these few simple steps, you'll never guess what the 3rd one is! about terminal HOT 14 OPEN

PhMajerus avatar PhMajerus commented on June 2, 2024
Freeze & crash Windows Terminal Preview 1.21.1272.0 with these few simple steps, you'll never guess what the 3rd one is!

from terminal.

Comments (14)

github-actions avatar github-actions commented on June 2, 2024 1

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

from terminal.

PhMajerus avatar PhMajerus commented on June 2, 2024 1

Does this only work with pens?

Yeah, it's a recent feature the shell team introduced to write directly in many common controls. For example we can ink directly inside a textbox or address bar using the pen.

image

This is intended to be a faster way to input text without having to display the tablet input panel (TabTip).
You'll need a device with a pen digitizer to test it out.

I suspect you're using or subclassing some common control, the shell attaches some overlay inking panel on top of it, and you destroy it without going through the original code that ensures the attached inking panel is properly disposed of, then it crashes when trying to access its parent HWND or something. This is just a wild guess though, I haven't checked how they implemented the Ink Anywere feature yet.

from terminal.

DHowett avatar DHowett commented on June 2, 2024

Dr. Watson as the grimmest reaper. I love it.

Would you be able to file feedback and reproduce the crash in the Apps > Terminal node and share the link with us?

I can't get this to happen locally . . . and I want to see if it's the same bug we just fixed with #17199.

from terminal.

PhMajerus avatar PhMajerus commented on June 2, 2024

Feedback Hub: https://aka.ms/AAqbvpz
I'm not sure it captured the proper dump though, only Windows Terminal shows in the apps list, no separate entry for Windows Terminal Preview.
Let me know.

from terminal.

PhMajerus avatar PhMajerus commented on June 2, 2024

I can get it to freeze every single time on a Surface Book 2 15", but cannot reproduce on an Intel NUC (NUC13ANKI50WC).

Could it be something GPU-related? The Surface Book 2 has always been a bit unreliable, even Edge sometimes restarts its rendering engine.

from terminal.

DHowett avatar DHowett commented on June 2, 2024

I'm seeing a thread tearing down a TSF::Implementation for a shell handwriting input method, a couple shell worker threads also stuck tearing down, and a window trying to update its acrylic background policy hanging also waiting for a shell worker thread. That's weird.

Watson cab 97512468-57cc-48ca-97d5-9721b4e3ec53

from terminal.

PhMajerus avatar PhMajerus commented on June 2, 2024

It's really weird, I could narrow it down to showing the appearance page for any shell, not necessarily the one being used in the other window.
But the settings has to be the tab tore off, if it's another shell window and then that window is used to show the settings and do everything similarly, then it won't crash.

So it has to be the settings page that is tore off to create a new window, and it has to show the appearance with the preview. You can navigate to another setting page again, as long as the preview has been displayed, it will crash.
If the settings is shown in the primary window or in a window created by tearing off another shell tab, it doesn't crash.

Is there some Atlas resources that are shared with the preview and may be freed when Settings is closed? Why would it only happen when the settings is tore off?

It is pretty easy to avoid the bug, and I cannot reproduce it on another system, so it's not a blocking issue by any means, but I feel like there must be some underlying issue that just happens to get less noticeable on other systems.

from terminal.

PhMajerus avatar PhMajerus commented on June 2, 2024

Could this be related?

image

I know Microsoft Surface Book 2 display drivers are somewhat unreliable, and Microsoft's Surface team never fixed the issue, Edge also sometimes has to restart its rendering, blacking out all rendering windows and recovering.

from terminal.

PhMajerus avatar PhMajerus commented on June 2, 2024

Attached another crash dump to the Feedback Hub report.
This one does not even freeze, it crashes directly, and doesn't involve the Settings page, it's just opening an Ubuntu WSL2 tab, doing apt update/upgrade/autoremove/autoclean, then exit to close the tab. Terminal shows the original cmd tab again and crashes immediately.
Again, this could be replicated every single time on my Surface Book 2.

from terminal.

scc23456 avatar scc23456 commented on June 2, 2024

try to disable "Shell handwriting" option in Windows Settings...

from terminal.

PhMajerus avatar PhMajerus commented on June 2, 2024

@scc23456 Good catch!
Indeed disabling the Shell handwriting feature seems to fix both crashes, and that would explain the shell handwriting input method that DHowett saw in the crash dump.

So there seems to be a problem between Terminal and "write anywhere", and this shows why it is important to try to test software on some devices with 👆 touch and đŸ–Šïž pen, not only on typical workstations.

from terminal.

lhecker avatar lhecker commented on June 2, 2024

I've got a laptop with touchscreen, I'm on 22635.3575, and I don't have a Shell Handwriting setting:
image

Does this only work with pens?

from terminal.

PhMajerus avatar PhMajerus commented on June 2, 2024

@lhecker Are you giving up on this one? I didn't see any similar crash with that feature in other apps, there is probably something Terminal does that makes it crash when that feature extends its controls.

from terminal.

DHowett avatar DHowett commented on June 2, 2024

Are you giving up on this one?

Please don't read too much into how we manage our issue assignments. 😅

from terminal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.