Coder Social home page Coder Social logo

Comments (7)

zadjii-msft avatar zadjii-msft commented on June 9, 2024

Is the end goal here to actually suspend the CLI application that's running connected to the Terminal, or just make it easier to select text in the scrollback/?

There's some related discussion in:

from terminal.

github-account1111 avatar github-account1111 commented on June 9, 2024

It's the former. It's strange to me that most participants of those issues seem to only be interested in the latter.

Especially that second one. It's not a bug, it's the default PowerShell behavior. It doesn't "freeze." As I mentioned in the description, you can easily tell if it's active or not by looking at the title bar.

from terminal.

zadjii-msft avatar zadjii-msft commented on June 9, 2024

Well, it's technically correct that it doesn't "freeze". But selecting in the vintage console prevents conhost from servicing any further console API calls. It just blocks the call until the selection is dismissed. That effectively pauses powershell (or any other CLI app) that's waiting on writing before continuing.

I'm guessing for most people (myself included) are just happy that selecting the Terminal accidentally doesn't entirely pause long builds anymore. I could have sworn there was an issue floating around asking for the ability to manually pause the conpty client, but I can't find anything like that now...

from terminal.

github-account1111 avatar github-account1111 commented on June 9, 2024

What's the issue with that behavior? You can just right-click to resume. Takes less than a second. Meanwhile potentially hours are wasted waiting for execution to finish, or execution has to be cancelled entirely. It also helps avoid overheating, especially if you use laptops or external drives.

You're basically eliminating a tiny little inconvenience (I even struggle to call it that, it's that inconsequential so long as you bother to look at the title bar) at the cost of quite a lot of fundamental functionality and usefulness.

from terminal.

lhecker avatar lhecker commented on June 9, 2024

Maybe you already know, but...

Actually you can still pause the output at any time: Just press the "Pause" or "Break" key. 😅 Almost all modern hardware and operating systems use the Pause/Break key for pausing terminal output. It's usually in the top right, above the Delete and Insert keys, if you have a full sized keyboard. If you don't have a Pause/Break key you can press Ctrl+S instead. On the latest Windows Terminal versions both should pause/freeze the output immediately until you press another key.

If you did already know that the Pause key does this, can you explain why it doesn't work for you?

from terminal.

lhecker avatar lhecker commented on June 9, 2024

You're basically eliminating a tiny little inconvenience (I even struggle to call it that, it's that inconsequential so long as you bother to look at the title bar) at the cost of quite a lot of fundamental functionality and usefulness.

Oh and... For what it's worth, I'm personally not opposed to implementing your suggestion, and I think you make an excellent argument for this feature. In fact I often did this myself (selecting to pause output), before I learned that the Pause key can be used for this.

However, we currently can't easily implement it correctly for architectural reasons (the entire ConPTY setup). It's certainly possible, for instance by sending a pause key press when selection starts and when it ends, but that's obviously going to be very error prone. For example, if someone had already paused output, or if we miss a key press somehow, or someone injects the pause key via the console APIs, in all those cases the thing the PTY sees and what Windows Terminal sees would get out of sync and you'd never be able to properly unpause the output anymore.

Given that other terminals don't seem to have this behavior, nor make it configurable, and that virtually all terminals support the Pause key and its Ctrl+S alias, I think this feature request may be too risky in my personal opinion.

from terminal.

carlos-zamora avatar carlos-zamora commented on June 9, 2024

Thanks for the feedback. As stated above, this is a bit risky of a change and the desired behavior should be accessible via the Pause key and its Ctrl+S alias. Closing 😊

from terminal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.