Coder Social home page Coder Social logo

Comments (5)

mani-ramaswamy avatar mani-ramaswamy commented on July 21, 2024

This should also be done in a backwards compatible manner, so if "fabric:/" is specified, we still accept it if that's the convention chosen. Or if the convention is not to specify "fabric:/", the CLI automatically removes it if the customer specifies it.

from service-fabric-cli.

echen805 avatar echen805 commented on July 21, 2024

@samedder, is it okay if I take this up? It looks like there's inconsistency between sfctl.custom_app.create and sfctl.custom_app.upgrade but thats the only one I've encountered

from service-fabric-cli.

Christina-Kang avatar Christina-Kang commented on July 21, 2024

@echen805 for sure! We would very much appreciate it! :)

from service-fabric-cli.

echen805 avatar echen805 commented on July 21, 2024

Great! So it looks like the functions that require application_id, do not want "fabric:/" in their value since the function automatically adds it at the beginning.

I looked through the contribution wiki and I did not see any ideas of which way I should go with this. Should I change parameter to application_name so future users will use a value with "fabric:/" in front? And make it backwards compatible so users who are currently using application_id will not be affected.

from service-fabric-cli.

echen805 avatar echen805 commented on July 21, 2024

Hi @Christina-Kang, is it okay if I still work on this?

from service-fabric-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.