Comments (5)
This should also be done in a backwards compatible manner, so if "fabric:/" is specified, we still accept it if that's the convention chosen. Or if the convention is not to specify "fabric:/", the CLI automatically removes it if the customer specifies it.
from service-fabric-cli.
@samedder, is it okay if I take this up? It looks like there's inconsistency between sfctl.custom_app.create and sfctl.custom_app.upgrade but thats the only one I've encountered
from service-fabric-cli.
@echen805 for sure! We would very much appreciate it! :)
from service-fabric-cli.
Great! So it looks like the functions that require application_id, do not want "fabric:/" in their value since the function automatically adds it at the beginning.
I looked through the contribution wiki and I did not see any ideas of which way I should go with this. Should I change parameter to application_name so future users will use a value with "fabric:/" in front? And make it backwards compatible so users who are currently using application_id will not be affected.
from service-fabric-cli.
Hi @Christina-Kang, is it okay if I still work on this?
from service-fabric-cli.
Related Issues (20)
- "(E_INVALIDARG) Invalid argument" sfctl compose create HOT 3
- Using "--no-verify" still getting "CERTIFICATE_VERIFY_FAILED" error HOT 7
- Timeout on provision HOT 8
- Update knack HOT 6
- Incorrect error message given if sudo is not provided
- ConnectionError: HTTPConnectionPool(host='localhost', port=19080) HOT 5
- Sfctl upload returns times out or returns cert error when other commands work HOT 5
- sfctl partition restart return (FMFailoverUnitNotFound) Null HOT 6
- Conflicts between service-fabric-cli and mock HOT 4
- sfctl throwing azure.servicefabric.models.fabric_error_py3.FabricErrorException: (NotFound) Null
- "sfctl cluster upgrade" fails with (FABRIC_E_FABRIC_ALREADY_IN_TARGET_VERSION) Fabric is already in this version HOT 7
- Add documentation about uploading and updating a single service
- Sfctl command to run Chaos test is failing with an error HOT 1
- Remove left over python 2 specifc code
- remove mesh commands
- [sfctl] TLS error: 'bad handshake: Unexpected EOF' when connecting to cluster HOT 1
- Add possibility to add unencrypted repository password on command line instead of promting it (sfctl compose)
- After Install via Windows Powershell, `sfctl` is not recognized
- migrate to new python SDK format
- This repo is missing important files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from service-fabric-cli.