Coder Social home page Coder Social logo

Comments (2)

michaelcfanning avatar michaelcfanning commented on June 9, 2024

Yes, this is clearly not correct. It raises the question as well, is the matcher properly dereferencing the artifact itself to determine whether there's been a change there that would warrant an 'updated' result (for example, if the artifact hash itself has changed). Complicated.

How much is this blocking you? I assume at this point you may have a workaround in the sense that you can simply treat updated as unchanged. Or are you building specific functionality around the updated state?

from sarif-sdk.

dmitrykobets-msft avatar dmitrykobets-msft commented on June 9, 2024

currently this is not blocking me since my workaround involves merging together the artifact lists from both baseline and candidate using a hand-written less strict ArtifactEqualityComparer. I update the ArtifactLocation indices inside the baseline and candidate results accordingly. That way both candidate and baseline will share the same artifact lists and indices so the baselineState won't be incorrectly set to updated.

from sarif-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.