Comments (2)
Yes, this is clearly not correct. It raises the question as well, is the matcher properly dereferencing the artifact itself to determine whether there's been a change there that would warrant an 'updated' result (for example, if the artifact hash itself has changed). Complicated.
How much is this blocking you? I assume at this point you may have a workaround in the sense that you can simply treat updated
as unchanged
. Or are you building specific functionality around the updated
state?
from sarif-sdk.
currently this is not blocking me since my workaround involves merging together the artifact lists from both baseline and candidate using a hand-written less strict ArtifactEqualityComparer
. I update the ArtifactLocation indices inside the baseline and candidate results accordingly. That way both candidate and baseline will share the same artifact lists and indices so the baselineState won't be incorrectly set to updated
.
from sarif-sdk.
Related Issues (20)
- Disable CodeQL rule 'cs/linq/missed-where'
- Add timeout to AnalyzeOptionsBase
- VALIDATION: validator flags absence of `rules` data on driver even if rule descriptors can be found in an extension.
- `FileRegionsCache` multiline context region generation needs a look.
- Make cache-results-by-file-hash configurable as a discrete option.
- In HDF->SARIF, include HDF's "controls.descriptions[label=check/fix]" as SARIF "help"
- Multitool convert options removed (--force, --pretty-print) HOT 4
- Supress can't remove empty results from Sarif json file? HOT 1
- Look for missing defaults between SARIF Spec and Json Schema file
- Specified Schema is 404 HOT 4
- Many references to old packages
- Suppression verb options
- This repo is missing important files HOT 4
- rewrite --insert "GitBlameInformation" throws NullReferenceException HOT 1
- Validating Visitor should not break on name changes
- [RULE REQUEST] Concise description of new analysis
- CPD conversion support
- HDF->SARIF converters missing location, making invalid for use by GitHub HOT 1
- HDF->SARIF converter output doesn't map status to kind/level/rank correctly HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sarif-sdk.