Comments (1)
Design A: split built logic
- Produce separate files for XAML and the custom WinMDs. The custom WinMD codegen would need to be part of the app
- This poses a problem since the custom codegen still needs to get linked into ReactNativeXaml, so we end up reaching into the app's project via msbuild props
- But also, RNX needs to have a winmd reference to the custom winmd so that cppwinrt can process it, so this would effectively still require modifying RNX under node_modules. An alternative would be to reuse the app's cppwinrt generated headers but this is very fragile (e.g. different versions of cppwinrt between the app and RNX would cause build breaks).
- moreover this complicates the codegen'd TS since
type
needs to be a set of known strings (known at codegen time). An alternative is to have a synthetic property on UserControl likeuserControlType
that is just a string (as opposed totype
which is a string union); we lose intellisense/type safety with this so not ideal either. - I played with this but I'm not sure this is a good way forward. Branch here: https://github.com/asklar/react-native-xaml/tree/buildLogic
Design B: view manager generator
- Codegen the whole view manager, not just the metadata. Then the app project just gets everything in one package
- Apps that only need XAML can use the view manager from the package, apps that need custom stuff will use the generated one
- It would make sense to split codegen into its own npm package, and have the XAML VM be wholly generated by it
- This could make it trickier to iterate on the VM (since the experience isn't great for T4 files, no intellisense, etc., it's just text)
- This is closer to what is possible today; you can run codegen and it will update the code in node_modules, and then you can copy the resulting RNX project into your project and get rid of the RNX npm package dependency
from react-native-xaml.
Related Issues (20)
- This repo is missing important files
- RNX views don't implement Constructor<NativeMethods> HOT 2
- ContentDialog Opens Only Once HOT 3
- Build error in example/windows/example.sln with Microsoft.ReactNative, 'Mso::MustBeNoExceptVoidFunctor: not a noexcept callable functor returning void' HOT 3
- Import WinUI package only if OverrideWinUIPackage is not set to "true"
- Allow user to override CppWinRT version
- Update projects to newer RNW versions HOT 3
- Extend `RunReactNativeXamlCodeGen` target to support multiple WinMDs HOT 1
- Update docs to clarify difference between using WinUI and system XAML components HOT 4
- JS Promises are not being processed and RN app crashes when changing pages/rendering new components HOT 1
- Package Failing to Build: No Matching Overload "SetPropValue" HOT 5
- Add support to specify ItemsPanel for ItemsControl elements such as GridView HOT 2
- MSB4011 warning when building HOT 3
- Upgrade to RN and RNW 0.72
- Support core components in SplitView / NavigationView HOT 2
- Crash when running under Application Verifier
- Remove checked in pfx files
- Update RNX to target RNW 0.73
- Data Grid Control with its sort, selection, filter, search, pagination & other data grid functions HOT 3
- Support ScrollIntoView for ListView HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-xaml.