The message for a pull request that is too large shows the wrong number about pr-metrics

[muiriswoulfe]

Hi @aerodynamica, thanks for using PR Metrics and for filing this issue.

Unfortunately, I'm unable to reproduce it. When I try to reproduce it, I find that if the PR is Medium or larger, the message correctly specifies the base size. And if the PR is Small or Extra Small, the message doesn't contain a size.

Could you verify that you've completed a re-run of PR Metrics after any change to the PR, in case the results you provided are originating from an older run of the task? Afterwards, if you continue to encounter the issue, could you provide any additional details that might help to diagnose what is different on your system.

[aerodynamica]

For a configuration with base-size = 50 and growth-factor = 2, you have the following sizes as a function of the number of lines changed:
0-49 lines: XS
50-99 lines: S
100-199 lines: M
200-399 lines: L
etc.

Now if you have a pull request with 70 lines of code changed, there will be no message. This is correct as the pull request is small (<100 lines).
But if you have a pull request with 140 lines of code changed, the message will be
❌ Try to keep pull requests smaller than 50 lines...
This is not correct, it should be
❌ Try to keep pull requests smaller than 100 lines...

[muiriswoulfe]

Thanks for clarifying @aerodynamica. I'll look to bring in a fix for this in the next release.