[Feature]: expose Frame Ids about playwright

[dgozman]

@himat Frame object is always the same for the same frame. guid is a part of the Frame object, but since it's an internal implementation detail, it might disappear at any moment as well.

[dgozman]

@himat Interoperating with CDP is not a goal for Playwright. The use of CDP is an implementation detail. If you'd like to work with CDP directly, feel free to retrieve the frame tree over CDP and call any protocol methods you'd like. Note that Playwright does not guarantee that it won't break after you call some CDP methods, so use it at your own risk.

Also, just wanted to check, but the frame object guid is entirely different from the actual Frame's ID right?

Yes, guid is a separate randomly generated id.

[dgozman]

@himat ID is an internal implementation detail. You can always create a Map<Frame, number> or use a symbol and lazily auto-generate ID for each frame.

const idMap = new Map<Frame, number>();
function getFrameId(frame: Frame) {
  if (!idMap.has(frame))
    idMap.set(frame, idMap.size + 1);
  return idMap.get(frame)!;
}

[himat]

@dgozman But that relies on only having one instance of a given Frame to make sure the reference comparison works right?
i.e. If I get a Frame at one point and store it in variable f1 and a Frame again later and store it in f2 (and say these came from two separate calls to page.frames()), then I want to ensure that if they're the same underlying frame that f1 === f2 should equal true.
And even if a Frame changes over time, does Playwright itself manage the frame internally to make sure that it always only has one reference to each Frame?

[himat]

I also noticed that playwright has an internal only guid field. Is that also stable, or are the guid assigned to each instance and therefore wouldn't work? In other words, are these guids, a unique UI on the reference or on the actual underlying value?

[himat]

@dgozman, ok so using Frame makes sense for that

But I have another usecase, where I need to reach into the CDP to listen for events since playwright does not expose these

  const cdpClient = await page.context().newCDPSession(page)
  await cdpClient.send("DOM.enable")
  await cdpClient.send("Network.enable")

  cdpClient.on("Network.requestWillBeSent", onNavigationStart)

  function onNavigationStart(params: Protocol.Network.RequestWillBeSentEvent) {
    const frames = page.frames()
    const navigationFrameId = params.frameId
    const isMainFrame = frames.find((frame) => frame.<ID??> === navigationFrameId) !== -1
    if (!isMainFrame) return
    ...
}

As you can see, I want to detect the navigation start for a page, and the RequestWillBeSentEvent gives me back a frameId, and I want to only run this algorithm on the main frame, but I can't do that here since you don't expose the frame ID.
Also, just wanted to check, but the frame object guid is entirely different from the actual Frame's ID right? Was wondering if I could even use the guid here even if temporarily even though its internal

[dgozman]

Closing as per above. If you encounter more problems, please file a new issue by filling in the "Bug Report" template.