Comments (3)
JoelEinbinder
commented on April 28, 2024
This gets tricky with whether waitForPopup should return only new popups, or query existing ones.
Dmitry needs the former. waitForNextPopup seems like a more explicit way of naming this. We may want to change browser.waitForTarget to be getOrWaitForTarget. We may also want to extend all of our event emitters with a fancy oncePromise method.
from playwright.
dgozman
commented on April 28, 2024
Generic waitForEvent now works for this thanks to #278. However, there is still a question whether we should only report popups after the first navigation is done, or provide some way to wait for it.
from playwright.
dgozman
commented on April 28, 2024
We now have popup.waitForLoadState which solves the first navigation issue.
from playwright.
Related Issues (20)
- [Bug]: DEBUG=pw:webserver no longer works (regression) HOT 2
- [Bug]: Locators do not auto-wait when resolved to multiple elements (Strict mode) HOT 4
- [Bug]: UI mode highlights all tests that import fixtures in red, despite running tests correctly; claims they shouldn't be imported HOT 1
- [Feature]: Support Ubuntu 24.04 HOT 1
- [Bug]: Viewing tests with -UI HOT 2
- Can't get more workers to run - Playwright HOT 3
- [Bug]: Since v1.43, "Error: Error: browserType.launch: Executable doesn't exist" HOT 2
- Can't get parallel running for multiple tests in same file - Playwright HOT 2
- [Bug]: Adding an assertion in a fixture does not trigger retries HOT 1
- [Bug]: No tests passing for a simple component (component testing) HOT 1
- [Feature]: Allow page to listen for custom events `page.on(CUSTOM_EVENT, () =>` HOT 5
- [Bug]: Unable to run playwright tests using github actions HOT 8
- [Bug]: Timing issues with dynamically generated tests. (Updated, originally thought this was a globbing issue) HOT 6
- [Question] Why is 'setDownloadBehavior' required for connect_over_cdp? Any workaround? HOT 1
- [Bug]: playwright tests do not show in test tab in vscode, no errors, cli works HOT 5
- [Bug]: invoke beforeall method with condition skip in loop will skip entire test instead of respective each loop tests HOT 5
- [Bug]: Arch Linux & your OS is not officially supported by Playwright HOT 1
- [Bug]: @tags added using new syntax as per v1.42 is not shown in UI mode HOT 1
- [Feature]: Set proxy in Page HOT 1
- [Bug]: Missing projects/tests when using multiple projects (folders) from 1.43.x HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from playwright.