Does not build on macOS about pict

[jaccz]

@wagnerst, cmake configs are new to this codebase and it would be great to troubleshoot this a bit more. Is this cmake-version dependent? I assume @bhardwajs (who introduced these configs recently) didn't see it in their environment.

I'll dust off my Mac to see what's going on but it will be a slow process. We can consider removing this flag from the config to unblock the compilation on MacOS until we understand it better.

[bhardwajs]

@wagnerst - The PR that introduced this change (#85) has a PR build on MacOS: https://pipelines.actions.githubusercontent.com/UYdpZu1K2Abbco3Gy7dEALkh0aw6QbWDK3pBQmV4Okx7ENc2Ng/_apis/pipelines/1/runs/381/signedlogcontent/3?urlExpires=2022-05-03T03%3A30%3A09.0046715Z&urlSigningMethod=HMACV1&urlSignature=AOgmhzVgg4uFpytZqIKdXtJ6y0RAeMPwYlmdjF0qH4k%3D
This build succeeded. So, I am wondering if there is something specific about the configuration you are using. Can you please share more details about the error and the setup of your build machine?

As @jaccz mentioned, I don't have a MacOS to test. And, I agree if understanding and resolving the issue is going to take time, removing this flag from MacOS config is a workaround.

[wagnerst]

So this is the error I get:

[ 52%] Building CXX object cli/CMakeFiles/pict_cli.dir/mparser.cpp.o
/Users/wagnerst/Stuff/ASTA 2022/pict/cli/mparser.cpp:369:20: error: if statement has empty body [-Werror,-Wempty-body]
if (found) ;
^
/Users/wagnerst/Stuff/ASTA 2022/pict/cli/mparser.cpp:369:20: note: put the semicolon on a separate line to silence this warning
1 error generated.
make[2]: *** [cli/CMakeFiles/pict_cli.dir/mparser.cpp.o] Error 1
make[1]: *** [cli/CMakeFiles/pict_cli.dir/all] Error 2
make: *** [all] Error 2

After running cmake --build build

I have installed the CMake using homebrew.
cmake has the version 3.23.1.
clang is Apple clang version 13.1.6 (clang-1316.0.21.2.3).

Anything else that can be helpful?

[jaccz]

Stefan, is that the only error you get? Seems to be coming from an assert statement that becomes "empty" in release builds. That is by design and the codebase uses the same coding pattern in many more places so presumably all of these are erroring out? We can go back to treating warnings as warnings and not errors but if we wanted a gentler fix in the meantime, I'd try to manipulate -Wempty-body. Either way, I need to try to reproduce this myself. I'll have some time on Friday and I'll see what I can find. From: Stefan Wagner ***@***.***> Sent: Wednesday, May 4, 2022 3:47 AM To: microsoft/pict ***@***.***> Cc: Jacek Czerwonka ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/pict] Does not build on macOS (Issue #89) So this is the error I get: [ 52%] Building CXX object cli/CMakeFiles/pict_cli.dir/mparser.cpp.o /Users/wagnerst/Stuff/ASTA 2022/pict/cli/mparser.cpp:369:20: error: if statement has empty body [-Werror,-Wempty-body] if (found) ; ^ /Users/wagnerst/Stuff/ASTA 2022/pict/cli/mparser.cpp:369:20: note: put the semicolon on a separate line to silence this warning 1 error generated. make[2]: *** [cli/CMakeFiles/pict_cli.dir/mparser.cpp.o] Error 1 make[1]: *** [cli/CMakeFiles/pict_cli.dir/all] Error 2 make: *** [all] Error 2 After running cmake --build build I have installed the CMake using homebrew. cmake has the version 3.23.1. clang is Apple clang version 13.1.6 (clang-1316.0.21.2.3). Anything else that can be helpful? - Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpict%2Fissues%2F89%23issuecomment-1117169877&data=05%7C01%7Cjacekcz%40microsoft.com%7C4f0bcbea2cc14ca1e6db08da2dbb5ebf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637872580015186351%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AnoVD0godG7Gn9VRvc%2B4Q5dxDQvxQiG88JNo2P51eJc%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACFRMVZFM3FPLHBZIRB4XADVIJIQZANCNFSM5UHXG4OA&data=05%7C01%7Cjacekcz%40microsoft.com%7C4f0bcbea2cc14ca1e6db08da2dbb5ebf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637872580015186351%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zkAYv8iEcKB5il3T7vK5hBPUBOQED0XGWB2mvcDaSDQ%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[jaccz]

Tracked it down. Here's the fix. #91
Silly but it seems to work. If you have a better idea on how this warning can be suppressed, let me know. Whatever the method, it needs to work on all supported compilers and platforms. Yuck.