Coder Social home page Coder Social logo

Comments (2)

fieldsJacksonG avatar fieldsJacksonG commented on May 30, 2024

Looks like this was missed when we fixed the interop between winrt::guid's and FGuid's.

In a previous block in the UpdateDeviceLocations function, you can change the memcpy from this:

check(sizeof(SpatialGraphNodeSpaceCreateInfo.nodeId) == sizeof(FGuid));
FMemory::Memcpy(&SpatialGraphNodeSpaceCreateInfo.nodeId, &DynamicNode.GetValue().Key, sizeof(SpatialGraphNodeSpaceCreateInfo.nodeId));

to this:

check(sizeof(SpatialGraphNodeSpaceCreateInfo.nodeId) == sizeof(FGuid));
winrt::guid SourceGuid = WMRUtility::FGUIDToGuid(DynamicNode.GetValue().Key);
FMemory::Memcpy(&SpatialGraphNodeSpaceCreateInfo.nodeId, &SourceGuid, sizeof(SpatialGraphNodeSpaceCreateInfo.nodeId));

Currently the FGuid is being set in the FindDynamicNode function using the inverse WMRUtility::GUIDToFGuid function, which correctly transcribes the guid. When the FGuid is copied back to a winrt::guid - the memcpy (without using FGuidToGUID) changes the order of the underlying guid components and then the spatial graph functions are using a different guid that isn't traced back to the camera node.

Fix upcoming

from microsoft-openxr-unreal.

fieldsJacksonG avatar fieldsJacksonG commented on May 30, 2024

#78

from microsoft-openxr-unreal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.