Comments (5)
The laxed implementation was definitely not intentional in the first place! I'm going to take a look at making a repro as a test for future fix here. I'll work to restore that functionality ASAP.
from lage.
Thanks @kenotron ! If we believe that the strictness is the right thing to do, then that also makes sense to me. Yes, it'll be bit of work - teams would have to fix their build graphs, but I think that is a good thing.
I'll let Lage team decide what's the right future here, but either ways, adding an example in documentation to clarify what is intended and what's not would be great!!
from lage.
So I think restoring default behavior is imperative - we can add a "--strict" or whatever to enforce many strictness things like file access, etc.
from lage.
Update 1: alright, locally I have a e2e test written with your case! (thanks for the small repro repo)
from lage.
Update 2: this is fixed in my latest (failed test is now green :))
from lage.
Related Issues (20)
- Documentation for v2 but install instructions for v1 HOT 4
- finding packages by package path
- lage should throw an error if NOTHING has been run by the command
- lage v2 --verbose broken? HOT 4
- lage v2: default reporting should be colorized HOT 1
- lage v2: Crash in yoga HOT 1
- lage v2: missing version number or --version option.
- v2: no targets found that matches the given scope. HOT 3
- Lage scheduler adding "phantom" tasks to the graph. HOT 1
- [RFC]: "Force Verbose" logging configuration for certain tasks HOT 1
- [RFC]: Add support for input patterns for tasks in lage.config
- [RFC]: Add functionality to compute hash of dependent targets.
- URL in menu when page is in mobile version is not clicable or very difficult to open
- lage version 2.5.2+ broken for lerna and pnpm workspaces. HOT 1
- [RFC]: Ability to provide CLI params as config
- Rust panic in 2.6.x HOT 4
- Feature Request: Log environmentGlob hash to console w/ running lage task (Dry run) HOT 1
- Lage throws error when ran outside git repo
- Cache invalidation issue for test files HOT 1
- Local cache not working in CI pipeline HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lage.