Coder Social home page Coder Social logo

Comments (1)

derekbekoe avatar derekbekoe commented on September 18, 2024

It's tricky finding a balance between making everything extensible and suggesting to subclass. In this case, I'd subclasses would be required anyway so you could subclass and provide your own implementation of create_command and then _command_handler.

In Azure CLI case, even if _command_handler was extensible, you'd still have to override create_command for this.

This is related to #12 but in that case, it was a single line you wanted to change to use a different class. Here, modifying _command_handler basically changes all of create_command anyway.

link to code in question: https://github.com/Microsoft/knack/blob/master/knack/commands.py#L106

from knack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.