Coder Social home page Coder Social logo

Comments (2)

Yukioru avatar Yukioru commented on May 16, 2024 1

Thanks, I will update the code in my project 👍🏻
I will watch for an update to makeStaticStyles().

This issue can be closed.

from griffel.

layershifter avatar layershifter commented on May 16, 2024

@Yukioru thanks for the interest and reporting 👍 There are two separate issues actually...

Proper configuration

We perform rehydration on the client, it's done in RendererProvider:

// "rehydrateCache()" can't be called in effects as it needs to be called before any component will be rendered to
// avoid double insertion of classes
rehydrateRendererCache(renderer, targetDocument);

The difference is in configuration, I updated your CodeSandbox (https://codesandbox.io/s/next-griffel-ssr-forked-2zok5q). In short the same instance of renderer should be used, for this RendererProvider should be moved to App:

// @document.jsx
     originalRenderPage({
        enhanceApp: (App) => {
          return function EnhancedApp(props) {
            return (
-              <RendererProvider renderer={renderer}>
-                <App {...props} />
+                <App {...props} renderer={renderer} />
-              </RendererProvider>
            );
          };
        }
      });
// @app.jsx
-function App({ Component, pageProps }) {
+function App({ Component, pageProps, renderer }) {
  return (
+    <RendererProvider renderer={renderer || createDOMRenderer()}>

Before

image

After

image

makeStaticStyles() does not support hydration

This was not implemented yet, but should... 🐱 I created a separate #44 to track this.

from griffel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.