Coder Social home page Coder Social logo

Comments (1)

arinwt avatar arinwt commented on May 21, 2024

This issue was discovered in 0.9, before DeltaManagerProxy was set to use the EventForwarder base class (introduced in this PR). This should be mostly resolved in 0.10+, because the EventForwarder does not subscribe to the source emitter events until someone listens to the forwarder for that event.

Problem (in 0.9):

  1. someone meaningfully listens to DeltaManager error event.
  2. DeltaManagerProxy listens to DeltaManager error event.
  3. nobody listens to DeltaManagerProxy error event.
  4. DeltaManager raises error event, calling all listeners.
  5. DeltaManagerProxy throws error because it has no error listeners.

Same flow with EventForwarder, no problem (in 0.10):

  1. someone meaningfully listens to DeltaManager error event.
  2. nobody listens to DeltaManagerProxy error event.
  3. because of (2), DeltaManagerProxy does not listen to DeltaManager error event.
  4. DeltaManager raises error event, calling all listeners.

But it could still happen with an unsubscribe (in 0.10):

  1. someone meaningfully listens to DeltaManager error event.
  2. someone listens to DeltaManagerProxy error event.
  3. because of (2), DeltaManagerProxy listens to DeltaManager error event.
  4. someone removes their only listener to DeltaManagerProxy error event.
  5. DeltaManager raises error event, calling all listeners.
  6. DeltaManagerProxy throws error because it has no error listeners.

I doubt this occurs in practice, because the proxy will likely be disposed which will disconnect it from the source emitter, but should still be fixed. When all listeners to a single event are removed from the proxy, it should stop listening to the source emitter for that event.

from fluidframework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.