Comments (5)
we should make it clear that provided Stardust Input component has one-to-one correspondence to input DOM element in general (so that any input attributes supplied to Input component should be reflected by its look and behavior)
I think this makes sense for any of our components that specifically target DOM elements and share names with them. Basically all of the Form components (TextArea, Input, etc).
Regarding names, I think any of these three are fine and have good semantics. If nobody has a pick for one over the others, I'd go with addon
for brevity. Other than that, I don't have a preference.
from fluent-ui-react.
I think the Label component should be renamed. Label is confusing, even when not used inside of an Input. Most other companies call a Label a Badge or Tag.
- https://www.lightningdesignsystem.com/components/badges/
- https://blueprintjs.com/docs/#core/components/tag
- https://material-ui.com/demos/badges/
from fluent-ui-react.
My absolute support on this proposal - also, we should make it clear that provided Stardust Input
component has one-to-one correspondence to input
DOM element in general (so that any input attributes supplied to Input
component should be reflected by its look and behavior) - and, at the same time we should provide these extensibility mechanism to enhance visual look of Input
for certain scenarios (see #120 (comment)).
So, long story short, my proposal is to make Input
component to be a strict superset over input
element's functionality. As an additional benefit, with this change we will eliminate base ground for the issues like the following: #194, where type='number'
is requested to be supported by Input
.
In regards to naming - generally agree with addon
proposal, but may suggest another couple of naming options:
decorator
adornment
(this is used by Material)
from fluent-ui-react.
Just noting, the Label name issue is discussed regularly among the team and we do want to solve it. We're working on an open source effort to find and standardize names. We'll announce that soon.
It is not here yet :/
from fluent-ui-react.
Whoa @levithomason! Yes, please. Honestly... I am surprised something like this does not yet exist.
from fluent-ui-react.
Related Issues (20)
- Memory leaks in FocusZone due to DOM object references not getting cleaned up
- Dropdown onSelectedChanged typings incorrect
- Bundle size: Single `themes` import imports all themes
- Bundle size: theme import imports several components HOT 2
- Toolbar with menu: trigger button always opens menu instead of toggling it
- Input's fluid property no effect when it is in a Form.Field?
- Dropdown value is [object Object] when selecting an item that is an object using DropdownItemProps HOT 3
- Carousel throws getItemPositionText is not a function
- How to change the Dropdown's container width? It is 22.25rem for now.
- Animation with no children throws
- Can't add custom colors to colorScheme? HOT 1
- Which technology to choose: office-ui-fabric-react vs fluent-ui-react HOT 1
- Toolbar overflow menu is misaligned/shifting rest of a page when clicked
- Tooltip: wrong outline on Button
- Popup: `offset` breaks arrow pointer
- [RFC] Implementing reveal highlight
- Popup: pointing beak is broken on edges HOT 1
- AccordionTitle content is not exposed as a slot
- README.md: Broken link in the "Why?" section
- Safari: Wrong focus indicator on Input
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.