Coder Social home page Coder Social logo

Comments (5)

brianespinosa avatar brianespinosa commented on May 17, 2024 2

we should make it clear that provided Stardust Input component has one-to-one correspondence to input DOM element in general (so that any input attributes supplied to Input component should be reflected by its look and behavior)

I think this makes sense for any of our components that specifically target DOM elements and share names with them. Basically all of the Form components (TextArea, Input, etc).

Regarding names, I think any of these three are fine and have good semantics. If nobody has a pick for one over the others, I'd go with addon for brevity. Other than that, I don't have a preference.

from fluent-ui-react.

codepretty avatar codepretty commented on May 17, 2024 1

I think the Label component should be renamed. Label is confusing, even when not used inside of an Input. Most other companies call a Label a Badge or Tag.

from fluent-ui-react.

kuzhelov avatar kuzhelov commented on May 17, 2024

My absolute support on this proposal - also, we should make it clear that provided Stardust Input component has one-to-one correspondence to input DOM element in general (so that any input attributes supplied to Input component should be reflected by its look and behavior) - and, at the same time we should provide these extensibility mechanism to enhance visual look of Input for certain scenarios (see #120 (comment)).

image

image

image

image

image

image

image

So, long story short, my proposal is to make Input component to be a strict superset over input element's functionality. As an additional benefit, with this change we will eliminate base ground for the issues like the following: #194, where type='number' is requested to be supported by Input.


In regards to naming - generally agree with addon proposal, but may suggest another couple of naming options:

  • decorator
  • adornment (this is used by Material)

from fluent-ui-react.

levithomason avatar levithomason commented on May 17, 2024

Just noting, the Label name issue is discussed regularly among the team and we do want to solve it. We're working on an open source effort to find and standardize names. We'll announce that soon.

It is not here yet :/

from fluent-ui-react.

brianespinosa avatar brianespinosa commented on May 17, 2024

Whoa @levithomason! Yes, please. Honestly... I am surprised something like this does not yet exist.

from fluent-ui-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.