Comments (4)
After thinking this through more, I also think proposal 1 is ideal. It introduces no new concepts or patterns. It is both more simple than proposal 2 and more powerful.
from fluent-ui-react.
My (still the same) opinion is if we access theme variables in component source, layers are broken.
I completely agree with the proposal to decouple it, I love Proposal 1.
from fluent-ui-react.
Agree with all the points provided. We've had similar discussion with @miroslavstastny where exactly the same points were raised by him - at that point we've decided to pass variables directly in component's logic, primarily for the sake of not introducing additional complexity for theme mechanisms that were just introduced then (and, thus, were not exploited enough to be considered as robust solution).
Speaking of the options suggested - I would definitely support the first one, as it suggests clear path that doesn't change but extends the approach we are using now - and, thus, it is not associated with significant increase of complexity. Also, this one seems to be flexible enough, so that with this one we would be able to address quite broad set of scenarios.
Not saying 'no' to the second option, though - but would rather wait once this concept will solidify in our minds, for the sake of us being absolutely sure about what we are buying for additional efforts laid in this direction, as well as whether this concept is able to cover all the cases we are interested in (and how flexible it would be to cover potentially emerged edge-cases)
from fluent-ui-react.
thanks - let me introduce PR for having more concrete discussion over the first option then..
from fluent-ui-react.
Related Issues (20)
- Memory leaks in FocusZone due to DOM object references not getting cleaned up
- Dropdown onSelectedChanged typings incorrect
- Bundle size: Single `themes` import imports all themes
- Bundle size: theme import imports several components HOT 2
- Toolbar with menu: trigger button always opens menu instead of toggling it
- Input's fluid property no effect when it is in a Form.Field?
- Dropdown value is [object Object] when selecting an item that is an object using DropdownItemProps HOT 3
- Carousel throws getItemPositionText is not a function
- How to change the Dropdown's container width? It is 22.25rem for now.
- Animation with no children throws
- Can't add custom colors to colorScheme? HOT 1
- Which technology to choose: office-ui-fabric-react vs fluent-ui-react HOT 1
- Toolbar overflow menu is misaligned/shifting rest of a page when clicked
- Tooltip: wrong outline on Button
- Popup: `offset` breaks arrow pointer
- [RFC] Implementing reveal highlight
- Popup: pointing beak is broken on edges HOT 1
- AccordionTitle content is not exposed as a slot
- README.md: Broken link in the "Why?" section
- Safari: Wrong focus indicator on Input
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluent-ui-react.