Comments (11)
It's quite common in python projects in general. When we talk about packages it's not that common. From what I've found
modin - https://github.com/modin-project/modin/blob/master/environment-dev.yml
river - https://github.com/online-ml/river/blob/main/pyproject.toml
anomalib - https://github.com/openvinotoolkit/anomalib/blob/main/.pre-commit-config.yaml
albumentations - https://github.com/albumentations-team/albumentations/blob/master/.pre-commit-config.yaml
optuna - https://github.com/optuna/optuna/blob/master/pyproject.toml
As an alternative you could enable ruff version of isort and use it.
from flaml.
I think worth trying.
from flaml.
@thinkall
Thank you for the reply.
That's the beauty of ruff: isort rules are integrated in it, so there won't be any new dependencies.
I'll make a PR this week.
from flaml.
In this note, can we enable/install his bot - https://github.com/marketplace/pre-commit-ci - so contributions like this will only update the configuration and the bot will perform the changes so it is clear what are the automated changes and what is additional enhancement...
from flaml.
If this one will get a go from the core, I can do a PR
from flaml.
I'm OK if it's a low-effort PR. @qingyun-wu what do you think?
from flaml.
Is it a common or rule-of-thumb practice to use isort? Do you know any other famous repo that also uses isort?
from flaml.
It's quite common in python projects in general. When we talk about packages it's not that common. From what I've found modin - https://github.com/modin-project/modin/blob/master/environment-dev.yml river - https://github.com/online-ml/river/blob/main/pyproject.toml anomalib - https://github.com/openvinotoolkit/anomalib/blob/main/.pre-commit-config.yaml albumentations - https://github.com/albumentations-team/albumentations/blob/master/.pre-commit-config.yaml optuna - https://github.com/optuna/optuna/blob/master/pyproject.toml
As an alternative you could enable ruff version of isort and use it.
What do you think? @sonichi @qingyun-wu
from flaml.
If this one will get a go from the core, I can do a PR
Hi @glevv , are you still interested in this? Thanks.
from flaml.
If this one will get a go from the core, I can do a PR
Hi @glevv , are you still interested in this? Thanks.
Yes, I can do this, but I need to know which route are we taking here: ruff version of isort (it will only require change in the config files) or original isort (it will be a new dev dependency)?
Either way it will be a change in the whole codebase (imports sort) and change in the pre-commit hook.
from flaml.
If this one will get a go from the core, I can do a PR
Hi @glevv , are you still interested in this? Thanks.
Yes, I can do this, but I need to know which route are we taking here: ruff version of isort (it will only require change in the config files) or original isort (it will be a new dev dependency)?
Either way it will be a change in the whole codebase (imports sort) and change in the pre-commit hook.
imports sort in this PR is what we wanted, so we won't see a lot imports sort in new PRs.
ruff version sounds better.
A quick question, what do you mean with original isort need a new dev dependency
? Do you mean we need to add isort into the dev virtual env? Wouldn't ruff version also install isort?
Thanks.
from flaml.
Related Issues (20)
- How to change value of max_iter in Logistic Regression in AutoML ?
- Custom Objective Function for LGBM
- Where can I get the corresponding model for each cross validation
- Parameter tuning in final_estimator with automl ensemble HOT 1
- couldn't get the same results with FLAML when using the original ML model HOT 1
- Represent "best error" in runtime logger instance using scientific notation? HOT 1
- custom_metric() function error HOT 1
- Preprocessing Data is missng ,raise key error. automl self was created data that is not repreat behaviour. HOT 1
- Typo or misnaming in automl/timeseries/ts_model.py
- Update Optuna HOT 1
- Shifting of Time Series data HOT 1
- BlendSearch in UDF mode HOT 1
- Official example: Time Series Forecast TypeError: 'NoneType' object is not callable HOT 2
- ml.py contains conflicting references to Numpy
- Cannot reproduce Flaml predictions using SkLearn RF HOT 1
- Wrong index during CV HOT 1
- Unable to work with root_mean_squared_log_error HOT 1
- Inconsistent naming
- automl broken with pandas 2 HOT 3
- Add (built-in) multi-target support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flaml.