Coder Social home page Coder Social logo

Comments (8)

bliptec avatar bliptec commented on May 19, 2024

There's also a task on me to clean up some suppressed warnings. This might make more sense to do once our set of ignored warnings is a lot smaller. Ideally, I'd also like to move our GN build file into this repo too, but I'm not sure how easy it is to set up GN outside of Chromium projects.

These are the internal suppressed warnings we have:
"-Wno-dangling-else", "-Wno-enum-compare-switch", "-Wno-header-hygiene", "-Wno-microsoft-enum-forward-reference", "-Wno-microsoft-extra-qualification", "-Wno-microsoft-goto", "-Wno-microsoft-template", "-Wno-pragma-once-outside-header", "-Wno-reorder", "-Wno-return-stack-address", "-Wno-self-assign", "-Wno-string-conversion", "-Wno-tautological-constant-out-of-range-compare", "-Wno-tautological-pointer-compare", "-Wno-unknown-pragmas", "-Wno-unused-function", "-Wno-unused-private-field", "-Wno-writable-strings",

from cpp_client_telemetry.

maxgolov avatar maxgolov commented on May 19, 2024

Unfortunately realistically we won't be able to tackle this at least until the end of August. Help is appreciated in this regard, to comment on how we can setup the builds for that using GitHub repo as source.

from cpp_client_telemetry.

maxgolov avatar maxgolov commented on May 19, 2024

GitHub-CI now has the rules to use ./build.sh (cmake) on Linux and Mac, plus hosted Azure Pipeline builds on Windows. If you can contribute a build file that utilizes 'gn' tool to build, like build-gn.sh or build-gn.cmd or a build flag to existing build scripts to use ninja, that would be greatly appreciated. Meanwhile I'd have to reforecast this to September.

from cpp_client_telemetry.

bliptec avatar bliptec commented on May 19, 2024

We have a deliverable to track work on adding automated tests for OneDS building with GN. Will discuss it on Friday in planning.

from cpp_client_telemetry.

maxgolov avatar maxgolov commented on May 19, 2024

@bliptec - I'm going thru the old backlog items. Currently we don't have GN setup... Unless it "might" work if we generate the GN build files from CMakeLists.txt... But I don't think we have cycles to spend on this. I'm suggesting to close this item. For now we rely on CMake + make and/or msbuild only. No GN.

from cpp_client_telemetry.

maxgolov avatar maxgolov commented on May 19, 2024

@bliptec - this one is stale. I know you guys have your own setup for that. I don't think currently we want to replicate this in our own CI. I'm closing it as Stale, feel free to reopen if you feel like some day you may help with integrating Chromium GN in our CI loop... but probably this is not a requirement for this semester.

from cpp_client_telemetry.

maxgolov avatar maxgolov commented on May 19, 2024

I'm reopening it, but with slightly adjusted goal in mind:

  • setup CMake build
  • with clang as a compiler on Windows
  • that uses usual ninja (now shipped in Visual Studio 2019) to build the SDK on Windows

This should be more or less 95% functionally similar to gn build (at least on Windows).

from cpp_client_telemetry.

maxgolov avatar maxgolov commented on May 19, 2024

Closing due to inactivity. Feel free to reopen. No plans to fix. Best solution would be to set up the usual cmake+ninja build (not gn).

from cpp_client_telemetry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.