Failing to resolve assemblies on macOS about coyote-samples

[cederstrom]

@pdeligia You are correct! I just aborted when I got the big red failure message 🤦‍♂️

The test is working fine after the rewrite 👍

[pdeligia]

Thanks @shaya-pb and @cederstrom. Just an update: we managed to identify and fix the issue. Basically the deadlock was happening because some of the assemblies where not rewritten properly (due to the assembly resolution error above), which then caused Coyote to not have full control of all the tasks in the test, resulting into a deadlock. The fix will be available in the next version of Coyote. Will close this issue when that happens.

[pdeligia]

Thanks for reporting this @cederstrom. I believe this should be benign and just a warning, if you see in the end it still says Done rewriting in 0.427981 sec. The issue arises I believe because it tries to resolve some system-level assemblies such as Microsoft.Extensions.Logging.Abstractions and does not find the location for them, but it should not really matter from the rewriters perspective. Could you try to run the tests after this rewriting step, and see if it still works for you?

[shaya-pb]

I think this should be reopened. I'm getting the same error on Windows 10, and the tests are not running correctly either: they're throwing a Unhandled exception 'System.IO.FileNotFoundException' was thrown in 'ImageGalleryTests': Could not load file or assembly 'Microsoft.Extensions.Logging.Abstractions, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified. exception.

And when I fix that (by moving the dll into the bin\coyote folder; I get the following exception when running the tests: Deadlock detected. Task(0) is waiting for a task to complete, but no other controlled tasks are enabled. - which is not the expected exception, if I'm not mistaken.

[pdeligia]

Thanks @shaya-pb for reporting, yes let me re-open this issue. This is a bit weird as it was working fine for me last time that I checked. Let us investigate.

Just to make sure, you did coyote rewrite and you were running the test on the rewritten dlls, right? (any rewritten dll should have the IsAssemblyRewrittenAttribute attribute in its metadata, this can be checked with a tool like ildasm or ilspy)

Btw, yea, this is not the expected exception, usually this happens if either (1) the assemblies-under-test have not been rewritten as mentioned above, or (2) there is uncontrolled concurrency (e.g. coming from an assembly that cannot be rewritten such as some system library -- but typically Coyote will report an explicit error saying something about detected uncontrolled concurrency and propose a workaround), or (3) if there is a genuine deadlock (but this should not be the case here).

[shaya-pb]

Thanks @pdeligia - I'm not sure if something else isn't going on here with dotnet test and Coyote rewrites. I opened issue microsoft/coyote#219 on Coyote which may be related.

[pdeligia]

Forgot to close this issue