ws.onerror about botframework-directlinejs

[billba]

The internal method observableWebSocket does throw errors. activity$ calls webSocketActivity$, which catches the errors from observableWebSocket and repeatedly attempts to reconnect to the webSocket.

Basically DirectLineJS handles every error condition as well as possible, and so if activity$ throws an error it means it has tried everything repeatedly, and nothing worked.

In the case of WebChat, we have a plan to have the UX reflect this state, but that code is not in place and so we don't handle the error right now. I admit that this is not ideal, but the new code is coming soon!

[vasilkrastev90]

Thanks for your response Bill.

I have played around with RX (https://jsfiddle.net/gk6se537/) and my understanding is that if there is some error caused by abnormal socket termination (as actually specified in code comments) then the retryWhen will cause the whole sequence to execute again. This means that a upon a successful recovery a new socket will be created. It should also seamlessly recover all messages possibly missed due to the error.

However a question that remains unanswered for me is that it seems that if the socket creation fails for some reason this error is not handled. i.e. ( https://jsfiddle.net/x2gnzv2y/ ) Am I missing something here?

[billba]

If WebSocket fails on creation it doesn't throw an error, it just calls onClose. This was certainly surprising to me when I was testing the code!