Changing docker file permissions breaks docker outside the container about azuretre

[marrobi]

@SJaffa hmm, the file is mounted in, as docker is running on your host machine so can't be edited just in the container.

What happens if you comment out the line specified above in the script? I've not hit the issue personally and it was added a fair while ago and the comment says it's specific to mac OS and codespaces.

This feels like more of a generic "How do I run docker inside a dev container without having to use sudo on mac OS and codespaces" question. Rather than TRE specific.

@stuartleeks shot in the dark, any ideas? Thanks.

[SJaffa]

If I comment that line out (or just stop it running that script entirely when it does make all) then nothing else seems to break but I am having some other Docker issues so not sure if that is related or not at the moment. When I fix my other issue I'll check if this was related or not.

[marrobi]

Actually, I've just replicated it on my machine, WSL:

➜  ~ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.3 LTS
Release:        22.04
Codename:       jammy

I only upgraded last week, not noticed it before. I can confirm docker group ID in WSL is different to that in the container.

[marrobi]

I can confirm if I stop that script running I see no adverse affects, and docker permissions do not get broken.

[SJaffa]

Yep just solved my other devcontainer/docker issue and it was unrelated, so I think removing this script is fine for me, but is there a way to stop this breaking things for anyone else on Linux? Or a different way to fix the original macOS/codespaces problem?

[marrobi]

Have verified that the script is needed on codespaces.

The only solution I can think of at present is to parse something from say docker info to only run the command in certain scenarios.

[marrobi]

In code spaces, we can check for:

CODESPACES=true

Actually, we could just run docker ps and check the exit code.

if ! docker ps > /dev/null 2>&1; then
  echo "docker ps failed, setting docker.sock permissions"
  sudo chgrp docker /var/run/docker.sock
  sudo chmod g+rw /var/run/docker.sock
fi

[marrobi]

I've done a PR, maybe you can test the fix and let me know. Thanks.