Comments (4)
bryanmacfarlane
commented on May 12, 2024
1
I don't think we should retry on 500
But, I wouldn't be opposed to retrying on these since they are temporary states:
502 Bad Gateway
The server was acting as a gateway or proxy and received an invalid response from the upstream server.
503 Service Unavailable
The server is currently unavailable (because it is overloaded or down for maintenance). Generally, this is a temporary state.
504 Gateway Timeout
The server was acting as a gateway or proxy and did not receive a timely response from the upstream server.
from azure-pipelines-tool-lib.
stephenmichaelf
commented on May 12, 2024
@janpieterz Thanks for reaching out with the suggestion! IMO we wouldn't want to do this for most of the 5xx error codes like internal server error, service unavailable, gateway timeout, etc. These are server errors and I am not sure, in the general case, that retrying will help. Most of the time I would guess that they are issues that need to be fixed on the server and that aren't resolved by waiting a little bit.
@bryanmacfarlane What do you think?
from azure-pipelines-tool-lib.
stephenmichaelf
commented on May 12, 2024
@janpieterz Would you like to make this change and do a PR? :)
from azure-pipelines-tool-lib.
janpieterz
commented on May 12, 2024
Yup, be happy to. Give me some time as I'm finishing up some things.
from azure-pipelines-tool-lib.
Related Issues (20)
- ⚠ Medium severity vuln found in [email protected], introduced via [email protected]
- Tool caching assumes semantic versions for tools HOT 3
- [NuGet tool installer] Certificate has expired HOT 3
- Support tools with non semver version HOT 1
- Next release? HOT 1
- Sample is broken
- v2.0.1 isn't working, missing transpiled js files HOT 1
- Exception "Aborted" when downloading tools from GitHub releases HOT 11
- This repo is missing important files HOT 1
- Documentation: Path for tool cache incorrect
- ##[error]Version spec 3.7 for architecture x64 did not match any version in Agent.ToolsDirectory. HOT 6
- Archive extraction hangs, when destination folder is already present. HOT 2
- [PERF] Extract directly to cache location HOT 2
- downloadTool not working behind an authenticated proxy. HOT 1
- Extract .tar.bz2 and .tar.xz files
- directory linux
- downloadTool towards github/aws fails due to old rest client
- Checking tool cache not working HOT 2
- Version spec 3.9 for architecture x64 did not match any version in Agent.ToolsDirectory. HOT 5
- Arbitrary Code Execution [High Severity][https://snyk.io/vuln/SNYK-JS-UNDERSCORE-1080984] in [email protected] HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-pipelines-tool-lib.