Coder Social home page Coder Social logo

Comments (6)

azchohfi avatar azchohfi commented on May 27, 2024 2

Ok, solution is to avoid the deasync code paths completely.
The problem is that whenever the deasync lib is called, the promises start to not work anymore. Solution? Don't go through the deasync code paths. How? Avoid the constructor that calls the sync methods.

Instead of doing:

let tr: ttm.MockTestRunner = new ttm.MockTestRunner(testPath, taskJsonPath)
await tr.runAsync()

Do:

let tr: ttm.MockTestRunner = new ttm.MockTestRunner()
await tr.LoadAsync(testPath, taskJsonPath);
await tr.runAsync()

It will completelly avoid calling deasync, as it won't call getNodePathSync

from azure-pipelines-task-lib.

azchohfi avatar azchohfi commented on May 27, 2024 1

I'm still having issues with newer version of this lib. The packages are now installing, but they fail to run:

Could not locate the bindings file. Tried:
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\build\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\build\Debug\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\build\Release\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\out\Debug\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\Debug\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\out\Release\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\Release\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\build\default\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\compiled\21.2.0\win32\x64\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\addon-build\release\install-root\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\addon-build\debug\install-root\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\addon-build\default\install-root\deasync.node
     → C:\Users\alzollin\source\repos\setup-msstore-cli\node_modules\deasync\lib\binding\node-v120-win32-x64\deasync.node

It is installing version 0.1.29 of deasync. I've tried forcing it to 0.1.28, but then it fails to build.

Version 0.1.29 has the node files in here:
.\node_modules\deasync\bin\win32-x64-node-21\deasync.node

from azure-pipelines-task-lib.

sverdlov93 avatar sverdlov93 commented on May 27, 2024

Hi, the addition on "deasync": "^0.1.28", to the package-json made our ndoe_modules 3 times bigger and our 30MB extension to 80MB extension.
Can you look into it?
@DenisRumyantsev

from azure-pipelines-task-lib.

ivanduplenskikh avatar ivanduplenskikh commented on May 27, 2024

@azchohfi, that is the problem related to missing binaries as I see.
There are no node20 binaries deasync-bin repository.

from azure-pipelines-task-lib.

ivanduplenskikh avatar ivanduplenskikh commented on May 27, 2024

@azchohfi I noticed binaries (node v19-21) that were uploaded 3 days ago.
I'm closing this ticket for now.

@sverdlov93 upgrading azure-pipelines-task-lib from 4.5.0 to 4.6.0 makes node_modules bigger by 7MB. Could you please double-check that your problem depends on deasync module? If your problem persists, feel free to create another issue.

from azure-pipelines-task-lib.

azchohfi avatar azchohfi commented on May 27, 2024

The specific issue was related to Jest itself. I had to add 'node' do the moduleFileExtensions in the jest.config.js.
Still, I'm facing a different issue now. deasyn doesn't seem to work with Jest:
abbr/deasync#156

from azure-pipelines-task-lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.