Coder Social home page Coder Social logo

Comments (28)

madhurig avatar madhurig commented on May 18, 2024 1

@JKennedy24 : Sorry for the delay. I am coming to the same conclusion that this new "group" field is now required for the feature to be usable. We will review and see if we can populate this by default. We have also been thinking of making it possible for customers to pass any additional arguments to fastlane in the task, that seems like a good idea here too.

Thanks,
Madhuri

from app-store-vsts-extension.

lkillgore avatar lkillgore commented on May 18, 2024

Hi @JKennedy24. I found this answer from fastlane's forum fastlane/fastlane#4002 (comment)

By any chance did you see something that looks like this in your log?

TestFlight requires you to provide the answer to the encryption question
to provide the reply, please add the following to your Info.plist file

<key>ITSAppUsesNonExemptEncryption</key><false/>

Afterwards re-build your app and try again

It's seems this setting is incompatible with TestFlight, and using it will give the same error you're receiving.

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

I didn't see that message in the log. all I saw was the message posted above.

should I try adding the attribute you have posted to my info.plist to get it to work?

from app-store-vsts-extension.

lkillgore avatar lkillgore commented on May 18, 2024

Hmm... It's interesting that you're not getting that message.

Yes, I think you should consider trying it out. (This link describes the implications: https://stackoverflow.com/questions/35739361/itsappusesnonexemptencryption-export-compliance-while-internal-testing) Alternatively, (if this is the issue) it appears that there is a submission process to allow your app to use that feature.

Also, do you know which version of fastlane you're using? If this is the issue and you're not getting the message I posted, I wonder if there may be a regression in fastlane or if the version you're using is out-of-date.

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

Thanks for the reply. I will try adding that key to my info.plist and try another release when I have an update and I will report back

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

I have added that to my info.plist and I now get the error:

2017-06-29T16:30:45.4636980Z [!] You must specify at least one group using the :groups option to distribute externally
2017-06-29T16:30:46.0587080Z ##[error]Error: fastlane failed with return code: 1

when trying to distribute to external testers

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

@JKennedy24 : Looks like a pilot bug that they fixed: fastlane/fastlane#8964. Can you check what version of fastlane is on your deployment machine? The task also has "Advanced" options to update the fastlane tools version or pin to a specific version.

Thanks,
Madhuri

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

@madhurig how would I find out the fastlane versioned installed on my deployment machine?

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

@JKennedy24: You can run "fastlane -v" to get the version number on the deployment machine. If you don't have access to the machine and are using a cloud solution, you can run the same in a shell script and include it in your build. The output will show up in the log.

Also, the task has an advanced option to install the latest fastlane tools for you. You can try using that option too.

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

@madhurig I have access to my deployment machine. Running fastlane returns not recognised. I'm guessing its not on the path and is located somewhere as part of the vsts agent?

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

@JKennedy24 : Can you check the version of deliver on your deployment machine by running "deliver -v"? Please attach a debug log from your build.

Thanks,
Madhuri

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

@madhurig I logged onto the deployment machine and ran deliver -v but got the same deliver is not recognised as an internal or external command I'm guessing that's not on the path either? Is there a specific directory I should be running this command in?

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

@JKennedy24 : try "gem list fastlane" and "gem list fastlane deliver". To update manually on the deployment machine run "gem update fastlane".

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

@madhurig Thanks for the reply. Have logged onto the deployment machine and ran gem list fastlane but again get gem is not recognised as an internal or external command

My deployment machine is a simple Windows 10 machine with VS2017 and Build agent running. All these commands sound like third party programs that are probably not installed or not on the path.

Should I be running them in a specific location? currently I am just running them in C:

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

@JKennedy24 : Publishing to the AppStore is only supported on macOS, we check for it in the tasks as well. Please verify if you have another machine in your agent queue.

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

I'm so sorry I just realised I've been running the commands on the wrong build machine! haha.

I have now ran these commands on my OSX MacBook-Pro

MacBook-Pro:~ user$ gem list fastlane

*** LOCAL GEMS ***


MacBook-Pro:~ user$ gem list fastlane deliver

*** LOCAL GEMS ***


MacBook-Pro:~ user$ fastlane -v
-bash: fastlane: command not found
MacBook-Pro:~ user$ gem update fastlane
Updating installed gems
Nothing to update

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

When I run "gem list fastlane", I get some version info on the console:

commander-fastlane (4.4.5)
fastlane (2.46.1, 2.44.0, 1.100.0)
fastlane_core (0.50.2)

Don't you see anything like that?

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

@madhurig Sorry for the delay in replying.

Running "gem list fastlane" returns a blank list. so I ran "gem list" and it returned this:

MacBook-Pro:~ me$ gem list

*** LOCAL GEMS ***

bigdecimal (1.2.0)
CFPropertyList (2.2.8)
io-console (0.4.2)
json (1.7.7)
libxml-ruby (2.6.0)
minitest (4.3.2)
nokogiri (1.5.6)
psych (2.0.0)
rake (0.9.6)
rdoc (4.0.0)
sqlite3 (1.3.7)
test-unit (2.0.0.0)

Very strange but looks like fastlane isnt installed?

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

Retried today with latest release cycle but still getting the same error:

You must specify at least one group using the :groups option to distribute externally
2017-06-29T16:30:46.0587080Z ##[error]Error: fastlane failed with return code: 1

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

I don't think this is an issue with the Fastlane version.

From this issue it says you must supply a group like so:

groups: ["MyExternalGroupNameAsSpecifiedIniTunesConnect"]

Nowhere in the file can I see where the group is being supplied.

I think this is the true error and this feature of "Release to a team of testers" will never work without it

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

Thanks @madhurig for getting back to me and confirming my suspicions. I will follow this thread for further updates

from app-store-vsts-extension.

grubstarstar avatar grubstarstar commented on May 18, 2024

I would also like to know when this is resolved as we're running into the same issue regarding :group not being specified. Thanks!

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

Fixed with latest release 1.126.0, let us know if you still see issues.

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

@madhurig I just tried to run our first test of distributing to external users but got an error:

2018-01-25T12:29:13.8815210Z [12:29:13]: Uploaded app 2.36 - 2.36.0, but received build 2.35 - 2.35.0. If you want to wait for uploaded build to be finished processing, use the wait_for_uploaded_build option
2018-01-25T12:29:17.3154290Z [12:29:17]: Successfully set the changelog for build
2018-01-25T12:29:17.3164460Z [12:29:17]: Distributing new build to testers: 2.35 - 2.35.0
2018-01-25T12:29:18.7536270Z
2018-01-25T12:29:18.7547600Z Looking for related GitHub issues on fastlane/fastlane...
2018-01-25T12:29:18.7551870Z
2018-01-25T12:29:19.3449030Z ➡️ Waiting for iTunes Connect to finish processing the new build
2018-01-25T12:29:19.3460800Z fastlane/fastlane#9664 [closed] 16 💬
2018-01-25T12:29:19.3470690Z 29 Nov 2017
2018-01-25T12:29:19.3474870Z
2018-01-25T12:29:19.3484860Z 🔗 You can ⌘ + double-click on links to open them directly in your browser.
2018-01-25T12:29:19.3497510Z /Users/myuser/.gem-cache/gems/fastlane-2.78.0/spaceship/lib/spaceship/test_flight/client.rb:290:in handle_response': [!] {"code"=>"ITC.response.error.INVALID_REQUEST", "description"=>"Failed to submit build for review."} (Spaceship::UnexpectedResponse) 2018-01-25T12:29:19.3510360Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/spaceship/lib/spaceship/test_flight/client.rb:72:in post_for_testflight_review'
2018-01-25T12:29:19.3522620Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/spaceship/lib/spaceship/test_flight/build.rb:204:in submit_for_testflight_review!' 2018-01-25T12:29:19.3534720Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/pilot/lib/pilot/build_manager.rb:149:in distribute_build'
2018-01-25T12:29:19.3546740Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/pilot/lib/pilot/build_manager.rb:88:in distribute' 2018-01-25T12:29:19.3558600Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/pilot/lib/pilot/build_manager.rb:52:in upload'
2018-01-25T12:29:19.3570600Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/pilot/lib/pilot/commands_generator.rb:66:in block (2 levels) in run' 2018-01-25T12:29:19.3582610Z from /Users/myuser/.gem-cache/gems/commander-fastlane-4.4.5/lib/commander/command.rb:178:in call'
2018-01-25T12:29:19.3594470Z from /Users/chrisjohn/.gem-cache/gems/commander-fastlane-4.4.5/lib/commander/command.rb:153:in run' 2018-01-25T12:29:19.3606470Z from /Users/myuser/.gem-cache/gems/commander-fastlane-4.4.5/lib/commander/runner.rb:476:in run_active_command'
2018-01-25T12:29:19.3618500Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:75:in run!' 2018-01-25T12:29:19.3630790Z from /Users/myuser/.gem-cache/gems/commander-fastlane-4.4.5/lib/commander/delegates.rb:15:in run!'
2018-01-25T12:29:19.3642680Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/pilot/lib/pilot/commands_generator.rb:166:in run' 2018-01-25T12:29:19.3654580Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/pilot/lib/pilot/commands_generator.rb:18:in start'
2018-01-25T12:29:19.3666510Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/fastlane/lib/fastlane/cli_tools_distributor.rb:90:in take_off' 2018-01-25T12:29:19.3678430Z from /Users/myuser/.gem-cache/gems/fastlane-2.78.0/bin/fastlane:20:in <top (required)>'
2018-01-25T12:29:19.3689970Z from /Users/myuser/.gem-cache/bin/fastlane:23:in load' 2018-01-25T12:29:19.3701390Z from /Users/myuser/.gem-cache/bin/fastlane:23:in

'
2018-01-25T12:29:19.3712890Z from /Users/myuser/.rvm/gems/ruby-2.4.2/bin/ruby_executable_hooks:15:in eval' 2018-01-25T12:29:19.3724570Z from /Users/myuser/.rvm/gems/ruby-2.4.2/bin/ruby_executable_hooks:15:in '

Interrestingly eventhough it failed the task the upload continued and it uploaded successfully to Itunes Connect but did not distribute to test users

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

@JKennedy24 : This seems to be something different unrelated to not specifying group. I only saw one fastlane issue on it reported by one customer but it was closed as no repro. Can you send me the full fastlane command line run by this release?

from app-store-vsts-extension.

JKennedy24 avatar JKennedy24 commented on May 18, 2024

@madhurig heres the command my release is running:

fastlane pilot upload -u ******** -i /Users/myuser/myagent/_work/r1/a/Daily Build - Xamarin.iOS/drop/MyAppiOS.ipa --changelog Test application -a com.mycompany.myapp --distribute_external true --groups myapp Testers

from app-store-vsts-extension.

madhurig avatar madhurig commented on May 18, 2024

@JKennedy24 : are you still seeing an issue here? I am able to distribute to my testers group without errors.

from app-store-vsts-extension.

KjellConnelly avatar KjellConnelly commented on May 18, 2024

Hey guys, I added a group for internal testers and it worked when I came across the 'add a groups error message'. To find this group, I just called:
fastlane pilot list -app_identifier XXXXXXXXXXX
This displayed a group for my current testers. I just used this string in my next call to pilot:
fastlane pilot add [email protected] --app_identifier XXXXXXXXXXX --groups ITC.apps.tf.labels.internalTesters

from app-store-vsts-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.