`set` and `remove` a cookie don't work together about cookie-universal

[microcipcip]

then it incorrectly sets the cookie - which seems to be redundant. My PR handled this.

You're right, I did it this way because the cookie that is set is invalid and immediately dismissed by the browser (set to expire in 1970), the code is also easier to understand.

I had initially tried with a more sophisticated approach with a filter (I implemented it in the set method, similar to your code), but I think that always setting it to invalid is more performant because before we had to check if the cookie existed with get and then set it. Now we only do set regardless, without additional logic specific to Frontend and SSR.

Anyway, let me know if it works 🤞

[dominikjasek]

I tested it and it works. Thanks for the release ❤️

[dominikjasek]

I prepared PR which fixes this #128

[microcipcip]

I don't understand this use case. Why would you set the cookie and remove it in the same request?

[dominikjasek]

At first glance this seems useless. However, when the application is really big and complex, this scenario may happen and thus this use-case is valid.

For example, my scenario is as follows:

• in nuxtServerInit, i set cookies including myCookie
• in page component there is a bunch of logic with plenty of $fetch functions
• one of those function is encapsulated in a try catch block and if the call fails, we want to remove a cookie myCookie

[microcipcip]

You convinced me :). I have pushed an update, can you please check v2.2.0? Apologies for not using your Pull Request, I wanted to add unit tests and there was an issue with setResponseCookie which would have run also in client side breaking the app. Let me know if it works.

[dominikjasek]

Thanks! I haven't tested yet but as far as I can see from changes, it lacks validation whether the cookie was set or not.

For example, if this is your nuxtServerInit function:

nuxtServerInit() {
  this.$cookies.remove('cookieWhichHasNeverBeenSet')
}

then it incorrectly sets the cookie - which seems to be redundant. My PR handled this.

[microcipcip]

Awesome!