do we want to create uuid for users if they don't have one cookied? about condor

[will123195]

+1 condor should probably save a cookie and push a unique cookieId for each user with every log

[kesla]

Does that really belong here? You can set/read cookies on the server, so we could do it here and then reduce the amount of data needed to be sent from condor.

[will123195]

Currently I can't tell from the logs if one user clicked 10 times, or if multiple users were on the same page at the same time.

I think we do need a visitorId column. It can be a small incrementing base62 number so we're only adding a few bytes.

[will123195]

And also visitorSessionId could increment after 30 minutes of inactivity. So we can determine Unique Visitors vs Visits.

[kesla]

@will123195 I didn't question the need to be able to identify a user, what I did question is if it's something that should be done here since we could do it in the server. But now that I come to think about it there's a potential race-condition in setting it on the server, so let's go with a cookie in the frontend.

I guess we could create a sessionId on the client, even though we also can get it from the logs... But it might be one of those things that would be fairly simple to add through a session cookie in here and then make getting data from the logs a lot eaiser.

[will123195]

@kesla ah i missed what you meant before. agreed.

[kesla]

@will123195 Alright, but like I wrote I changed my mind so let's add it here. I'd gladly review a PR if you have the bandwidth for it, otherwise I could take a look at adding it a bit later.