Coder Social home page Coder Social logo

Comments (24)

Micke-K avatar Micke-K commented on July 24, 2024 1

3.2.3 released with a fix for this. ALL items will now be returned. Please report back how the experience is your environments with 4000+ objects. Will it be impossible because it takes too long time or is it "acceptable".

I will most likely keep looking into this to be able to page or load additional pages in the view but return all objects when exporting, documenting etc.

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024 1

Thank you both for testing and reporting back!

I've been thinking about the search. Not sure how to implement it in the best way though. I do agree that it would be best if search/filter generates a new API query. That would probably require some re-write of the list APIs.

Cheers!

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024 1

You can filter "better" in 3.5.0. If you specify a filter and press Refresh, it will only load applications based on the filter.

Have a try and let me know how it goes

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024

Hello Andi,

Thank you for the support and for reporting this. I have been waiting for an issue like this. I know that I need to add paging support in the code so I will look into this.

Graph API has different default based on the API, sometimes 100 and sometimes 1000. I'll add automatic paging to it. However, in a case like this it might be painful since you will get ~4500 items. The data grid can handle it since it uses virtualisation but the scrolling experience will most likely be horrible.

Adding paging is probably going to be the easy part. Making it look good might be way harder. I'll try to implement the paging this weekend or during the week.

Btw...~4500 apps. That is an impressive environment :)

from intunemanagement.

ASMailer avatar ASMailer commented on July 24, 2024

Hey Micke,

Thank you very much for your commitment

Yes, understand, it is precisely in the details that the challenge lies.
With the amount of objects we have to use the filter anyway and restrict the view. Otherwise you won't find anything :-)

If there is anything I can test or help, let me know.

Thx
Andi

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024

Hello!

I've started this but I've been working every night this week. It might take a bit longer than I thought. I am sorry about that!

from intunemanagement.

Phoenix-DH avatar Phoenix-DH commented on July 24, 2024

I started today also using your tool, great one!
I have exactly the same issue ... more than 1000 entries, maybe not only in the apps section.
Having the nextlinks included would be great!
No hurry.

from intunemanagement.

Phoenix-DH avatar Phoenix-DH commented on July 24, 2024

Fo sure it will take longer, but it is working.
Pagination would also be fine if it is quicker, but you need to have all items available to use the filter.

Will try to use it for a preriod of time and give reply.

from intunemanagement.

ASMailer avatar ASMailer commented on July 24, 2024

I will most likely keep looking into this to be able to page or load additional pages in the view but return all objects when exporting, documenting etc.

... that would be the most efficient implementation in the end ...

from intunemanagement.

ASMailer avatar ASMailer commented on July 24, 2024

... i´m already happy ...:-) works really great. We will continue to work with it and see how it goes.

Thank you very much

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024

Hello!

This was fixed in the December update. You will now get two buttons to either download the next batch or download the rest.

Have you tested it yet?

Cheers!

from intunemanagement.

Phoenix-DH avatar Phoenix-DH commented on July 24, 2024

Hey, not now.... Will do! Thanks.

from intunemanagement.

Phoenix-DH avatar Phoenix-DH commented on July 24, 2024

Hey @Micke-K,

I had a look to the applications. In my case a saw the objects amount of 8614 in the bottom line.
Does that now mean I got all visible?

Was there a change in the meanwhile again, because there are no buttons ;)

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024

Hmmm that is interesting. So the code only calls it once (single page) and should only return a 1000 objects. Not sure if MS has changed this in the background or I have a bug I can't find. I can force my page size to be 10 and that works great. I have a little bit of problem testing 1000 more objects in my environment :)

Can you try updating MSGraph.psm1. Search for #$params.Add("pageSize",10). Remove # and change size to 500. Should now look like:

$params.Add("pageSize",500)

Cheers!

from intunemanagement.

Phoenix-DH avatar Phoenix-DH commented on July 24, 2024

Thats not in the code ... completely not. I only find something with

        elseif($AllPages -eq $true -and $HttpMethod -eq "GET" -and $ret.value -is [Array])
        {
            $allValues += $ret.value
            if($ret.'@odata.nextLink')
            {
                $Url = $ret.'@odata.nextLink'
            }
        }

Seems that you are doing this by default ...

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024

Sorry, I had pageSize at 100 in my original test. It should be at row 489. At least in version 3.4.0.

if($SinglePage -eq $true) { #Use default page size or use below for a specific page size for testing #$params.Add("pageSize",100) }

Cheers!

from intunemanagement.

Phoenix-DH avatar Phoenix-DH commented on July 24, 2024

Oh ... version 3.4?
I used only the download button what might not download 3.4. but 3.2.3

How can I grab all new files? I'm not so familiar to github to be honest.

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024

Ah sorry, that is me being confusing :)

I don't like creating a release until I know it is ok. I think I must change my whole release process...

You can download the master directly. Go to the code page and click Code and then Download Zip

https://github.com/Micke-K/IntuneManagement/archive/refs/heads/master.zip

from intunemanagement.

ASMailer avatar ASMailer commented on July 24, 2024

from intunemanagement.

Phoenix-DH avatar Phoenix-DH commented on July 24, 2024

Works alsom for me now.

from intunemanagement.

Phoenix-DH avatar Phoenix-DH commented on July 24, 2024

Will try ...

But means that I now have not to change the code again after downloading 3.5.0?

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024

At least not until the next version is released :)

from intunemanagement.

ASMailer avatar ASMailer commented on July 24, 2024

from intunemanagement.

Micke-K avatar Micke-K commented on July 24, 2024

Closing this. Please open a new Issue if it is not working as intended.

Cheers!

from intunemanagement.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.