Comments (4)
undefined in this context means not set.
the module calling updateDom() says the content changed. it's the module's job to tell MagicMirror. we don't compare old vs new.
from magicmirror.
in modules where I don't want the change flash, I return the same Dom object tree I built last(first) time. so the replace is identical.
the browser knows if the dom elements are different or not.
more and more the browsers are implementing a shadow Dom. memory access is significantly faster than screen drawing,
so they draw to a shadow compare and draw diffs to the screen
from magicmirror.
the module calling updateDom() says the content changed. it's the module's job to tell MagicMirror. we don't compare old vs new.
updateDom
calls updateDomWithContent
which literally calls moduleNeedsUpdate
whose sole purpose is to compare the header and body of the new module content with the current content to determine if an update is needed. It just doesn't work when the header is null because undefined !== "undefined"
.
from magicmirror.
cool.. I am wrong.. so, edit the code and try it out.. see what happens.. all you have to do is remove 2 quotes..
you can use the developers window (ctrl-shift-i) , sources tab , to put a stop on this line of code and checkout the behavior now
i don't see any difference.. that line of code is called once at startup of module..
from magicmirror.
Related Issues (20)
- move sunclac devdependency to dependencies HOT 1
- Small proposed change to hourly weather precipitation probability styling HOT 4
- Architecture suggestion: new “data sources” category
- Non helpful error message when started in clientonly mode HOT 6
- MMM-OnSpotify module causes MagicMirror to draws things multiple times HOT 10
- online documentation missing many config options for default modules HOT 3
- [weather] unit of config is not respected on broadcasted notifications
- online doc initial page on android phone hamburger menu doesnt respond HOT 7
- short dayname with time there HOT 4
- [calendar] Wrong values on broadcasted fullday events with RRULE
- Initializing buttons using 'MMM-Buttons' for notification sending to 'MMM-StopwatchTimer' induces an error :( HOT 1
- [weather] openweathermap One Call 2.5 will be finally closed in June 2024 HOT 2
- [news feed][feature request] ignore HTML tags in news feed items
- Error magicmirror 2.27 after upgrade - Blank black screen HOT 5
- Crash on Start possibility HOT 8
- PR 2881 extended calendar to receive notifications from other modules, but code in wrong place
- [weather] openmeteo precipitationProbability not shown in forecast
- newsfeed enclosured picture feature HOT 6
- [weather] openmeteo hourly does not work into next day
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magicmirror.