Coder Social home page Coder Social logo

Comments (7)

michelesalvador avatar michelesalvador commented on June 11, 2024

You are right. I missed this change on Android 13.
I will fix this bug for the next release (version 0.9.2).
I wrote a FAQ about that, with a possible workaround.

from familygem.

michelesalvador avatar michelesalvador commented on June 11, 2024

@tobikster are you still available to create a fix?

It should be:

  • add READ_MEDIA_IMAGES READ_MEDIA_VIDEO READ_MEDIA_AUDIO in the manifest
  • check/request these permissions at once where needed in MediaFoldersActivity and F

At once I mean that a Media could virtually contain any kind of file, not only images.

from familygem.

tobikster avatar tobikster commented on June 11, 2024

Sure. I started preparing some fix, but I abandoned it when you assigned this issue to yourself πŸ™‚.
I can resume this work and prepare a PR.

from familygem.

michelesalvador avatar michelesalvador commented on June 11, 2024

Thank you!
Sorry because I changed my mind.

from familygem.

tobikster avatar tobikster commented on June 11, 2024

No problem πŸ™‚

Now I understand why you refers to MediaFoldersActivity β€” my changes based on the version before the translation πŸ˜„

Fortunately, they weren't big, so it was easy to apply the fixes again in the new files.

I noticed, that the permissions check before importing the GEDCOM file was removed with the changes to code translation.
This is the same as I noticed β€” it looks like in this case no permission is required.
So, I made the changes only in the media cases: while attaching a media to a person and selecting media folders.

from familygem.

michelesalvador avatar michelesalvador commented on June 11, 2024

Good job. Thank you!

the permissions check before importing the GEDCOM file was removed

Yes, the permissions check is actually not needed with ACTION_GET_CONTENT.

from familygem.

michelesalvador avatar michelesalvador commented on June 11, 2024

This bug has been fixed with commit 9d11b40 and released on Family Gem 0.9.2 (7db7cd2)

from familygem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.