Comments (7)
You are right. I missed this change on Android 13.
I will fix this bug for the next release (version 0.9.2).
I wrote a FAQ about that, with a possible workaround.
from familygem.
@tobikster are you still available to create a fix?
It should be:
- add
READ_MEDIA_IMAGES
READ_MEDIA_VIDEO
READ_MEDIA_AUDIO
in the manifest - check/request these permissions at once where needed in MediaFoldersActivity and F
At once I mean that a Media could virtually contain any kind of file, not only images.
from familygem.
Sure. I started preparing some fix, but I abandoned it when you assigned this issue to yourself π.
I can resume this work and prepare a PR.
from familygem.
Thank you!
Sorry because I changed my mind.
from familygem.
No problem π
Now I understand why you refers to MediaFoldersActivity
β my changes based on the version before the translation π
Fortunately, they weren't big, so it was easy to apply the fixes again in the new files.
I noticed, that the permissions check before importing the GEDCOM file was removed with the changes to code translation.
This is the same as I noticed β it looks like in this case no permission is required.
So, I made the changes only in the media cases: while attaching a media to a person and selecting media folders.
from familygem.
Good job. Thank you!
the permissions check before importing the GEDCOM file was removed
Yes, the permissions check is actually not needed with ACTION_GET_CONTENT
.
from familygem.
This bug has been fixed with commit 9d11b40 and released on Family Gem 0.9.2 (7db7cd2)
from familygem.
Related Issues (20)
- Other media HOT 2
- Half-siblings in graph, ordering HOT 3
- Fun Feature HOT 2
- [Feature] Add Monochrome/adaptive app icon HOT 1
- Help all trees lost HOT 4
- Automatic local backup HOT 5
- Option to export ALL trees HOT 8
- [Feature] Add support for lunar calendar HOT 2
- PDF-Medias canΒ΄t be found in media folder HOT 5
- Notification about anniversaries HOT 2
- MAYBE other color for marriage
- Tree merge is broken HOT 3
- Option to show in-laws HOT 2
- Cleartext Traffic HOT 2
- History book
- Export whole family tree in PDF HOT 1
- Tree corrupt: "Can't get useful data" HOT 4
- no white background in system dark mode HOT 2
- Export PNG
- Divorced Parents? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from familygem.