Coder Social home page Coder Social logo

Comments (2)

michael-rubel avatar michael-rubel commented on June 12, 2024

Hi @stanley-hypo

I noticed the inconsistency in the DefinesModelRelations trait, as this trait was supposed to define relations, not the concrete models. You're unable to eager load because it loads the model immediately in that method by using first. The fix is PRed already and will be shipped in the next major release of the package. The delay is because it's a breaking change for those who may have overriden that method. For now, I recommend creating a separate model and extend from MichaelRubel\Couponables\Models\Coupon, then adding a method:

public function redeemerRelation(): MorphTo
{
    return $this->morphTo();
}

And you'll able to eager load it:

$coupons = Coupon::with('redeemerRelation')->get();

I hope this helps! 🙂

from laravel-couponables.

stanley-hypo avatar stanley-hypo commented on June 12, 2024

thanks so much

from laravel-couponables.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.