Closing sessions about gulp-connect-php

[micahblu]

Not at all, let's go for it

[micahblu]

Sorry for the late reply on this. Can you please provide me some environment specifics? What os, php version etc.

[vieko]

Hey there, I just ran into this issue on OSX Sierra with PHP 5.6/7.0/7.1 – the php process simply does not terminate when I stop the gulp task from running. Managed to kill the process by locating it first with lsof -i tcp:8000 and then killing the PID. Any thoughts? Thanks in advance.

EDIT: sometimes things will work as expected. Managed to reproduce a few times however.

[grmartin]

@vieko I am presently in the process of reworking portions of this, including its dependence on lsof. The current status of where i am in this is available here: #41

You are welcome (encouraged) to test that out and see how it goes.

Please direct any bugs against 1.0.0 WIP against the other repo (https://github.com/grmartin/gulp-connect-php). Once it is merged in to this one, bug tracking will move here, i simply do not wish to muddy the waters in this repo until after that branch is mainlined.

[grmartin]

1.0.0 is now in the primary master branch of the original repository. See: http://github.com/micahblu/gulp-connect-php.

[grmartin]

This ticket will close on or near 17 May 2017 unless updated.

[dylanspurgin]

I am also seeing the behavior where the server does not stop when the gulp process is ended (MacOS). My gulp task looks like this:

gulp.task('connect', ['browsersync'], function () {
    connect.server({ base: config.wordpress.dest, port: 8001, debug: true, open: false});
});

[grmartin]

So, Gulp 3 uses orchestrator. Presently our library doesn't implement any binding to Gulp's events. That would be why its not 'automatically' stopping, there is a closeServer call.

For now i would suggest adding a handler yourself... Should be something much like this (based on @dylanspurgin's code in his comment):

gulp.task('connect', ['browsersync'], function () {
    connect.server({ base: config.wordpress.dest, port: 8001, debug: true, open: false}, function() {
    	gulp.on('stop', function _gulp_php_stopper() {
    		connect.closeServer();
    	});
    });
});

I will however add this to my TODO list.

[grmartin]

@micahblu, I can add this but I'd like to make it so it can be opted out from via a configure parameter... any issues with that conceptually?

[Jikstra]

So, Gulp 3 uses orchestrator. Presently our library doesn't implement any binding to Gulp's events. That would be why its not 'automatically' stopping, there is a closeServer call.

For now i would suggest adding a handler yourself... Should be something much like this (based on @dylanspurgin's code in his comment):

gulp.task('connect', ['browsersync'], function () {
   connect.server({ base: config.wordpress.dest, port: 8001, debug: true, open: false}, function() {
   	gulp.on('stop', function _gulp_php_stopper() {
   		connect.closeServer();
   	});
   });
});

I will however add this to my TODO list.

Not sure why, but for me the gulp stop event gets fired way to early. I replaced it with following code and seems to work, even if it also feels hacky.

      process.on('exit', () => {
          console.log('Shutting down php server');
          gulpConnectPhp.closeServer()
      });