Coder Social home page Coder Social logo

Comments (4)

mholt avatar mholt commented on July 18, 2024

I'll definitely consider this for version 3.0 which is well under way, because I think it could be really useful. In the mean time, how about using a variable defined in a scope that both hooks can access?

from papaparse.

mholt avatar mholt commented on July 18, 2024

@achambers I'm implementing this feature tonight. I'm thinking that the before hook will work a little differently than it does now. Right now, you can return a variety of things: an object to redefine the config, "skip" to skip, false to abort, and nothing (undefined) to continue. I'm going to standardize it so that if you do return anything, you always return an object that can look like this:

{
    action: "abort",
    reason: "some reason",
    config: { /* custom config for just this file */ }
}

Each property is optional. Not returning anything or not specifying an action or specifying an action of "continue" will carry on as normal. The action can also be "abort" or "skip". Only an action of "abort" will raise an error, but the reason will be carried into the error handler (which I'm still figuring out). If you want to adjust the config for a certain file, you can specify it in the config property.

Sound good?

from papaparse.

mholt avatar mholt commented on July 18, 2024

Closing unless this still needs attention. Thanks again for the feedback!

from papaparse.

achambers avatar achambers commented on July 18, 2024

Sorry @mholt. Didn't get around to replying. Yep, that sounds like a reasonable solution. I'll work it in to what I have when you're done and will see how it feels.
Nice work mate.

from papaparse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.