Comments (2)
Hi @jonathangjertsen , thanks for reporting the issue.
Using _ in identifiers is not idiomatic in Go, that is why the rule complains on record_
Sure, the proposed fix (record
) is not valid because it results to be a reserved word of the language. It could be possible to avoid these kinds of incorrect recommendations by checking against the list of reserved words.
In these cases, it could be tricky to propose an alternative name. Thus, the rule could just signal the naming problem without proposing a fix.
IMO, adding these checks isn't worth the performance and complexity penalities.
In your case, you could just use something like strukt
to avoid the names clash.
from revive.
I will close the issue for now, and if it turns out to be impacting a larger number of users, I'll reopen it.
from revive.
Related Issues (20)
- detect unnecessary gomock controller Finish call HOT 4
- modifies-value-receiver ignores modification to maps and slices HOT 1
- var-naming rule to check that plural vars with ID are capitalised HOT 7
- Add a linter rule to enforce omitting the type for the same type arguments in a function HOT 3
- add-constant suggests invalid fix of replacing struct tags with string constants for anonymous structs HOT 2
- New release (1.3.5) HOT 1
- Cannot install 1.3.5 HOT 9
- replace directive error in latest tag / release HOT 1
- Cannot install 1.3.5 but 1.3.3 works HOT 1
- `unhandled-error`: error message function name does not match name used for exclusions
- Expand `unused-parameter` to check anonymous functions HOT 1
- next phase of refactoring from black and white to block and allow HOT 2
- enforce-slice-style: Add declaration style HOT 8
- False Positive in rule max-control-nesting HOT 3
- False positive datarace detection in Go 1.22 HOT 2
- comment-spacings exceptions do not work if there's no colon after the exception HOT 2
- Possible false positive confusing-naming error on generics with pointer type receiver HOT 2
- duplicate-imports linter broken? HOT 3
- out-of-order rules in documentation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from revive.